* [PATCH v2 5/9] kernel: padata : use this_cpu_read per-cpu helper
@ 2012-11-02 16:01 Shan Wei
2012-11-02 17:46 ` Christoph Lameter
2012-11-03 8:24 ` Steffen Klassert
0 siblings, 2 replies; 3+ messages in thread
From: Shan Wei @ 2012-11-02 16:01 UTC (permalink / raw)
To: steffen.klassert, Kernel-Maillist, linux-crypto, cl, Shan Wei
From: Shan Wei <davidshan@tencent.com>
Signed-off-by: Shan Wei <davidshan@tencent.com>
---
kernel/padata.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/kernel/padata.c b/kernel/padata.c
index 89fe3d1..cf94137 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -171,7 +171,7 @@ static struct padata_priv *padata_get_next(struct parallel_data *pd)
{
int cpu, num_cpus;
unsigned int next_nr, next_index;
- struct padata_parallel_queue *queue, *next_queue;
+ struct padata_parallel_queue *next_queue;
struct padata_priv *padata;
struct padata_list *reorder;
@@ -204,8 +204,7 @@ static struct padata_priv *padata_get_next(struct parallel_data *pd)
goto out;
}
- queue = per_cpu_ptr(pd->pqueue, smp_processor_id());
- if (queue->cpu_index == next_queue->cpu_index) {
+ if (this_cpu_read(pd->pqueue->cpu_index) == next_queue->cpu_index) {
padata = ERR_PTR(-ENODATA);
goto out;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 5/9] kernel: padata : use this_cpu_read per-cpu helper
2012-11-02 16:01 [PATCH v2 5/9] kernel: padata : use this_cpu_read per-cpu helper Shan Wei
@ 2012-11-02 17:46 ` Christoph Lameter
2012-11-03 8:24 ` Steffen Klassert
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Lameter @ 2012-11-02 17:46 UTC (permalink / raw)
To: Shan Wei; +Cc: steffen.klassert, Kernel-Maillist, linux-crypto
On Sat, 3 Nov 2012, Shan Wei wrote:
> - queue = per_cpu_ptr(pd->pqueue, smp_processor_id());
> - if (queue->cpu_index == next_queue->cpu_index) {
> + if (this_cpu_read(pd->pqueue->cpu_index) == next_queue->cpu_index) {
> padata = ERR_PTR(-ENODATA);
Reviewed-by: Christoph Lameter <cl@linux.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 5/9] kernel: padata : use this_cpu_read per-cpu helper
2012-11-02 16:01 [PATCH v2 5/9] kernel: padata : use this_cpu_read per-cpu helper Shan Wei
2012-11-02 17:46 ` Christoph Lameter
@ 2012-11-03 8:24 ` Steffen Klassert
1 sibling, 0 replies; 3+ messages in thread
From: Steffen Klassert @ 2012-11-03 8:24 UTC (permalink / raw)
To: Shan Wei; +Cc: Kernel-Maillist, linux-crypto, cl
>
> @@ -204,8 +204,7 @@ static struct padata_priv *padata_get_next(struct parallel_data *pd)
> goto out;
> }
>
> - queue = per_cpu_ptr(pd->pqueue, smp_processor_id());
> - if (queue->cpu_index == next_queue->cpu_index) {
> + if (this_cpu_read(pd->pqueue->cpu_index) == next_queue->cpu_index) {
This runs with bottom halves off, so we can use __this_cpu_read here.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-03 8:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-02 16:01 [PATCH v2 5/9] kernel: padata : use this_cpu_read per-cpu helper Shan Wei
2012-11-02 17:46 ` Christoph Lameter
2012-11-03 8:24 ` Steffen Klassert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox