From: Thomas Hellstrom <thellstrom@vmware.com>
To: Dave Airlie <airlied@gmail.com>
Cc: airlied@redhat.com, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] drm/ttm, drm/vmwgfx: Use RCU locking for object lookups v3
Date: Tue, 20 Nov 2012 07:44:34 +0100 [thread overview]
Message-ID: <50AB26D2.5090602@vmware.com> (raw)
In-Reply-To: <CAPM=9txb2aQ6zXYKdxDiuL0jOBA9epM_kBT8zeOOcUDN42gQ_w@mail.gmail.com>
On 11/20/2012 07:19 AM, Dave Airlie wrote:
> On Tue, Nov 6, 2012 at 9:31 PM, Thomas Hellstrom <thellstrom@vmware.com> wrote:
>> The mostly used lookup+get put+potential_destroy path of TTM objects
>> is converted to use RCU locks. This will substantially decrease the amount
>> of locked bus cycles during normal operation.
>> Since we use kfree_rcu to free the objects, no rcu synchronization is needed
>> at module unload time.
> As this is the first use of RCU in a drm driver from what I can see,
> let me remind that the
> RCU patent agreement AFAIK only covers GPL works.
>
> So non-GPL or other OSes porting this code should take not of this.
>
> Dave.
From VMware's side this won't be a problem, since other VMware kernel
modules (VMCI IIRC) use RCU.
In any case I have a new version of the "vmwgfx optimization" patch
series that mostly add documentation and
annotation (by using a drm_ht_xxx_rcu) interface for hashtab, after an
internal review by Dmitry Torkov. I see you've already
applied the original patch series. Do you want me to send out the new
one or rebase it against current drm-next?
Thanks,
Thomas
next prev parent reply other threads:[~2012-11-20 7:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 11:31 [PATCH 0/4] drm/ttm: Get rid of a number of atomic read-modify-write ops v3 Thomas Hellstrom
2012-11-06 11:31 ` [PATCH 1/4] drm: Make hashtab rcu-safe Thomas Hellstrom
2012-11-06 11:31 ` [PATCH 2/4] kref: Implement kref_get_unless_zero v3 Thomas Hellstrom
2012-11-06 11:31 ` [PATCH 3/4] drm/ttm, drm/vmwgfx: Use RCU locking for object lookups v3 Thomas Hellstrom
2012-11-20 6:19 ` Dave Airlie
2012-11-20 6:44 ` Thomas Hellstrom [this message]
2012-11-20 7:59 ` Dave Airlie
2012-11-06 11:31 ` [PATCH 4/4] drm/ttm: Optimize reservation slightly Thomas Hellstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AB26D2.5090602@vmware.com \
--to=thellstrom@vmware.com \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox