* [PATCH v3] tty: Add driver unthrottle in ioctl(...,TCFLSH,..).
@ 2012-11-26 22:09 Ilya Zykov
0 siblings, 0 replies; 2+ messages in thread
From: Ilya Zykov @ 2012-11-26 22:09 UTC (permalink / raw)
To: Alan Cox; +Cc: Greg Kroah-Hartman, linux-kernel, linux-serial, ilya
Regression 'tty: fix "IRQ45: nobody cared"'
Regression commit 7b292b4bf9a9d6098440d85616d6ca4c608b8304
Function reset_buffer_flags() also invoked during the ioctl(...,TCFLSH,..).
At the time of request we can have full buffers and throttled driver too.
If we don't unthrottle driver, we can get forever throttled driver, because,
after request, we will have empty buffers and throttled driver and
there is no place to unthrottle driver.
It simple reproduce with "pty" pair then one side sleep on tty->write_wait,
and other side do ioctl(...,TCFLSH,..). Then there is no place to do writers wake up.
Signed-off-by: Ilya Zykov <ilya@ilyx.ru>
---
diff --git a/drivers/tty/tty_ioctl.c b/drivers/tty/tty_ioctl.c
index 12b1fa0..a038be1 100644
--- a/drivers/tty/tty_ioctl.c
+++ b/drivers/tty/tty_ioctl.c
@@ -1098,10 +1098,12 @@ int tty_perform_flush(struct tty_struct *tty, unsigned long arg)
case TCIFLUSH:
if (ld && ld->ops->flush_buffer)
ld->ops->flush_buffer(tty);
+ tty_unthrottle(tty);
break;
case TCIOFLUSH:
if (ld && ld->ops->flush_buffer)
ld->ops->flush_buffer(tty);
+ tty_unthrottle(tty);
/* fall through */
case TCOFLUSH:
tty_driver_flush_buffer(tty);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v3] tty: Add driver unthrottle in ioctl(...,TCFLSH,..).
@ 2012-11-26 23:15 Ilya Zykov
0 siblings, 0 replies; 2+ messages in thread
From: Ilya Zykov @ 2012-11-26 23:15 UTC (permalink / raw)
To: Alan Cox; +Cc: Greg Kroah-Hartman, linux-serial, linux-kernel, ilya
Sorry. Correct patch format.
Regression 'tty: fix "IRQ45: nobody cared"'
Regression commit 7b292b4bf9a9d6098440d85616d6ca4c608b8304
Function reset_buffer_flags() also invoked during the ioctl(...,TCFLSH,..).
At the time of request we can have full buffers and throttled driver too.
If we don't unthrottle driver, we can get forever throttled driver, because,
after request, we will have empty buffers and throttled driver and
there is no place to unthrottle driver.
It simple reproduce with "pty" pair then one side sleep on tty->write_wait,
and other side do ioctl(...,TCFLSH,..). Then there is no place to do writers wake up.
Signed-off-by: Ilya Zykov <ilya@ilyx.ru>
---
diff --git a/drivers/tty/tty_ioctl.c b/drivers/tty/tty_ioctl.c
index 12b1fa0..a038be1 100644
--- a/drivers/tty/tty_ioctl.c
+++ b/drivers/tty/tty_ioctl.c
@@ -1098,10 +1098,12 @@ int tty_perform_flush(struct tty_struct *tty, unsigned long arg)
case TCIFLUSH:
if (ld && ld->ops->flush_buffer)
ld->ops->flush_buffer(tty);
+ tty_unthrottle(tty);
break;
case TCIOFLUSH:
if (ld && ld->ops->flush_buffer)
ld->ops->flush_buffer(tty);
+ tty_unthrottle(tty);
/* fall through */
case TCOFLUSH:
tty_driver_flush_buffer(tty);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-26 23:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-26 23:15 [PATCH v3] tty: Add driver unthrottle in ioctl(...,TCFLSH,..) Ilya Zykov
-- strict thread matches above, loose matches on Subject: below --
2012-11-26 22:09 Ilya Zykov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox