* [PATCH] x86, efi: remove attribute check from setup_efi_pci
@ 2013-01-29 16:52 Maarten Lankhorst
2013-01-29 17:54 ` Matt Fleming
0 siblings, 1 reply; 2+ messages in thread
From: Maarten Lankhorst @ 2013-01-29 16:52 UTC (permalink / raw)
To: Matthew Garrett, Matt Fleming
Cc: dri-devel@lists.freedesktop.org, Sasha Levin, LKML, linux-efi,
x86
It looks like the original commit that copied the rom contents from efi always copied
the rom, and the fixup in setup_efi_pci from commit 886d751a2ea99a160
("x86, efi: correct precedence of operators in setup_efi_pci") broke that.
This resulted in macbook pro's no longer finding the rom images, and thus not being able to use the radeon card any more.
The solution is to just remove the check for now, and always copy the rom if available.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
---
diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
index 18e329c..ce06324 100644
--- a/arch/x86/boot/compressed/eboot.c
+++ b/arch/x86/boot/compressed/eboot.c
@@ -302,9 +302,6 @@ static efi_status_t setup_efi_pci(struct boot_params *params)
if (status != EFI_SUCCESS)
continue;
- if (!(attributes & EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM))
- continue;
-
if (!pci->romimage || !pci->romsize)
continue;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] x86, efi: remove attribute check from setup_efi_pci
2013-01-29 16:52 [PATCH] x86, efi: remove attribute check from setup_efi_pci Maarten Lankhorst
@ 2013-01-29 17:54 ` Matt Fleming
0 siblings, 0 replies; 2+ messages in thread
From: Matt Fleming @ 2013-01-29 17:54 UTC (permalink / raw)
To: Maarten Lankhorst
Cc: Matthew Garrett, dri-devel@lists.freedesktop.org, Sasha Levin,
LKML, linux-efi, x86
On Tue, 2013-01-29 at 17:52 +0100, Maarten Lankhorst wrote:
> It looks like the original commit that copied the rom contents from efi always copied
> the rom, and the fixup in setup_efi_pci from commit 886d751a2ea99a160
> ("x86, efi: correct precedence of operators in setup_efi_pci") broke that.
>
> This resulted in macbook pro's no longer finding the rom images, and thus not being able to use the radeon card any more.
>
> The solution is to just remove the check for now, and always copy the rom if available.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-29 17:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-29 16:52 [PATCH] x86, efi: remove attribute check from setup_efi_pci Maarten Lankhorst
2013-01-29 17:54 ` Matt Fleming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox