public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Vankar, Chintan" <c-vankar@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>, Tero Kristo <kristo@kernel.org>,
	Vignesh Raghavendra <vigneshr@ti.com>, <srk@ti.com>,
	<s-vadapalli@ti.com>, <danishanwar@ti.com>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Roger Quadros <rogerq@kernel.org>
Subject: Re: [PATCH v4 2/2] arm64: dts: ti: k3-am62p*/k3-j722s: Add bootph-all property to enable Ethernet boot
Date: Wed, 30 Apr 2025 11:18:52 +0530	[thread overview]
Message-ID: <511ef271-ed0b-40b6-9abc-9fce0081d25b@ti.com> (raw)
In-Reply-To: <20250429112728.m54x2jwyjykcuus7@unzip>

Hello Nishanth,

On 4/29/2025 4:57 PM, Nishanth Menon wrote:
> On 12:56-20250429, Chintan Vankar wrote:
>> Ethernet boot requires CPSW nodes to be present starting from R5 SPL
>> stage. Add bootph-all property to required nodes to enable Ethernet boot
>> for AM62P5-SK and J722S-EVM.
>>
>> Reviewed-by: Roger Quadros <rogerq@kernel.org>
>> Signed-off-by: Chintan Vankar <c-vankar@ti.com>
>> ---
>>
>> Link to v3:
>> https://lore.kernel.org/r/20250425051055.2393301-3-c-vankar@ti.com/
>>
>> Changes from v3 to v4:
>> - No changes.
>>
>>   arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 3 +++
> 
> Please notice that we have the same problem[1] here as well.
> 
> [1] https://lore.kernel.org/all/20250425212427.vvyocc4mmne5g3vq@vividly/

I have added "bootph-all" property in the common file of J722S-EVM and 
AM62P5-SK since we are enabling Ethernet boot for both the boards. Are
you referring to move the nodes I have added in
"k3-am62p-j722s-common-main.dtsi" to respective board files,
"k3-am62p5-sk.dts" and "k3-j722s-evm.dts".

Regards,
Chintan.

> 
>>   arch/arm64/boot/dts/ti/k3-am62p5-sk.dts                | 2 ++
>>   arch/arm64/boot/dts/ti/k3-j722s-evm.dts                | 3 +++
>>   3 files changed, 8 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
>> index 7b65538110e8..11f484f88603 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
>> @@ -50,6 +50,7 @@ phy_gmii_sel: phy@4044 {
>>   			compatible = "ti,am654-phy-gmii-sel";
>>   			reg = <0x4044 0x8>;
>>   			#phy-cells = <1>;
>> +			bootph-all;
>>   		};
>>   
>>   		epwm_tbclk: clock-controller@4130 {
>> @@ -730,6 +731,7 @@ cpsw_port1: port@1 {
>>   				mac-address = [00 00 00 00 00 00];
>>   				ti,syscon-efuse = <&cpsw_mac_syscon 0x0>;
>>   				status = "disabled";
>> +				bootph-all;
>>   			};
>>   
>>   			cpsw_port2: port@2 {
>> @@ -751,6 +753,7 @@ cpsw3g_mdio: mdio@f00 {
>>   			clock-names = "fck";
>>   			bus_freq = <1000000>;
>>   			status = "disabled";
>> +			bootph-all;
>>   		};
>>   
>>   		cpts@3d000 {
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
>> index d29f524600af..5b2f0945a9eb 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
>> @@ -227,6 +227,7 @@ main_mdio1_pins_default: main-mdio1-default-pins {
>>   			AM62PX_IOPAD(0x0160, PIN_OUTPUT, 0) /* (F17) MDIO0_MDC */
>>   			AM62PX_IOPAD(0x015c, PIN_INPUT, 0) /* (F16) MDIO0_MDIO */
>>   		>;
>> +		bootph-all;
>>   	};
>>   
>>   	main_mmc1_pins_default: main-mmc1-default-pins {
>> @@ -496,6 +497,7 @@ &cpsw3g_mdio {
>>   
>>   	cpsw3g_phy0: ethernet-phy@0 {
>>   		reg = <0>;
>> +		bootph-all;
>>   		ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>;
>>   		ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
>>   		ti,min-output-impedance;
>> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
>> index 34b9d190800e..93d770c5792e 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
>> @@ -310,6 +310,7 @@ mdio_pins_default: mdio-default-pins {
>>   			J722S_IOPAD(0x0160, PIN_OUTPUT, 0) /* (AC24) MDIO0_MDC */
>>   			J722S_IOPAD(0x015c, PIN_INPUT, 0) /* (AD25) MDIO0_MDIO */
>>   		>;
>> +		bootph-all;
>>   	};
>>   
>>   	ospi0_pins_default: ospi0-default-pins {
>> @@ -344,6 +345,7 @@ J722S_IOPAD(0x0140, PIN_OUTPUT, 0) /* (AF24) RGMII1_TD3 */
>>   			J722S_IOPAD(0x0130, PIN_OUTPUT, 0) /* (AG26) RGMII1_TXC */
>>   			J722S_IOPAD(0x012c, PIN_OUTPUT, 0) /* (AF25) RGMII1_TX_CTL */
>>   		>;
>> +		bootph-all;
>>   	};
>>   
>>   	main_usb1_pins_default: main-usb1-default-pins {
>> @@ -388,6 +390,7 @@ &cpsw3g_mdio {
>>   
>>   	cpsw3g_phy0: ethernet-phy@0 {
>>   		reg = <0>;
>> +		bootph-all;
>>   		ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>;
>>   		ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
>>   		ti,min-output-impedance;
>> -- 
>> 2.34.1
>>
> 

  reply	other threads:[~2025-04-30  5:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-29  7:26 [PATCH v4 0/2] Add bootph-all property to necessary nodes to enable ethernet boot for AM68-SK, J722s and AM62p-SK Chintan Vankar
2025-04-29  7:26 ` [PATCH v4 1/2] arm64: dts: ti: k3-am68-sk-base-board: Add bootph-all property to enable Ethernet boot Chintan Vankar
2025-04-29  7:26 ` [PATCH v4 2/2] arm64: dts: ti: k3-am62p*/k3-j722s: " Chintan Vankar
2025-04-29 11:27   ` Nishanth Menon
2025-04-30  5:48     ` Vankar, Chintan [this message]
2025-05-02 12:00       ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=511ef271-ed0b-40b6-9abc-9fce0081d25b@ti.com \
    --to=c-vankar@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=danishanwar@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=s-vadapalli@ti.com \
    --cc=srk@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox