* [PATCH v4 0/2] Add bootph-all property to necessary nodes to enable ethernet boot for AM68-SK, J722s and AM62p-SK
@ 2025-04-29 7:26 Chintan Vankar
2025-04-29 7:26 ` [PATCH v4 1/2] arm64: dts: ti: k3-am68-sk-base-board: Add bootph-all property to enable Ethernet boot Chintan Vankar
2025-04-29 7:26 ` [PATCH v4 2/2] arm64: dts: ti: k3-am62p*/k3-j722s: " Chintan Vankar
0 siblings, 2 replies; 6+ messages in thread
From: Chintan Vankar @ 2025-04-29 7:26 UTC (permalink / raw)
To: Conor Dooley, Krzysztof Kozlowski, Rob Herring, Tero Kristo,
Vignesh Raghavendra, Nishanth Menon
Cc: srk, s-vadapalli, danishanwar, c-vankar, linux-kernel, devicetree,
linux-arm-kernel
This series adds bootph-all property to necessary nodes to enable
ethernet boot support for AM68-SK, J722s and AM62p-SK.
This series is based on linux-next tagged next-20250428.
Link to v3:
https://lore.kernel.org/r/20250425051055.2393301-1-c-vankar@ti.com/
Changes from v3 to v4:
- As per Nishanth's suggestion, moved nodes which require "bootph-all"
property into board specific file for AM68-SK.
Chintan Vankar (2):
arm64: dts: ti: k3-am68-sk-base-board: Add bootph-all property to
enable Ethernet boot
arm64: dts: ti: k3-am62p*/k3-j722s: Add bootph-all property to enable
Ethernet boot
.../boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 3 +++
arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 2 ++
arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 12 ++++++++++++
arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 3 +++
4 files changed, 20 insertions(+)
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v4 1/2] arm64: dts: ti: k3-am68-sk-base-board: Add bootph-all property to enable Ethernet boot 2025-04-29 7:26 [PATCH v4 0/2] Add bootph-all property to necessary nodes to enable ethernet boot for AM68-SK, J722s and AM62p-SK Chintan Vankar @ 2025-04-29 7:26 ` Chintan Vankar 2025-04-29 7:26 ` [PATCH v4 2/2] arm64: dts: ti: k3-am62p*/k3-j722s: " Chintan Vankar 1 sibling, 0 replies; 6+ messages in thread From: Chintan Vankar @ 2025-04-29 7:26 UTC (permalink / raw) To: Conor Dooley, Krzysztof Kozlowski, Rob Herring, Tero Kristo, Vignesh Raghavendra, Nishanth Menon Cc: srk, s-vadapalli, danishanwar, c-vankar, linux-kernel, devicetree, linux-arm-kernel Ethernet boot requires CPSW nodes to be present starting from R5 SPL stage. Add bootph-all property to required nodes to enable Ethernet boot on AM68-SK. Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com> Signed-off-by: Chintan Vankar <c-vankar@ti.com> --- Link to v3: https://lore.kernel.org/r/20250425051055.2393301-2-c-vankar@ti.com/ Changes from v3 to v4: - As per Nishanth's suggestion, moved nodes which require "bootph-all" property into board specific file for AM68-SK. arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts index 5fa70a874d7b..e84c504c87d2 100644 --- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts @@ -344,6 +344,7 @@ J721S2_WKUP_IOPAD(0x008, PIN_OUTPUT, 0) /* (E22) MCU_RGMII1_TD3 */ J721S2_WKUP_IOPAD(0x018, PIN_OUTPUT, 0) /* (F21) MCU_RGMII1_TXC */ J721S2_WKUP_IOPAD(0x000, PIN_OUTPUT, 0) /* (F22) MCU_RGMII1_TX_CTL */ >; + bootph-all; }; mcu_mdio_pins_default: mcu-mdio-default-pins { @@ -351,6 +352,7 @@ mcu_mdio_pins_default: mcu-mdio-default-pins { J721S2_WKUP_IOPAD(0x034, PIN_OUTPUT, 0) /* (A21) MCU_MDIO0_MDC */ J721S2_WKUP_IOPAD(0x030, PIN_INPUT, 0) /* (A22) MCU_MDIO0_MDIO */ >; + bootph-all; }; mcu_mcan0_pins_default: mcu-mcan0-default-pins { @@ -412,6 +414,14 @@ J721S2_WKUP_IOPAD(0x000, PIN_INPUT, 7) /* (K26) WKUP_GPIO0_49 */ }; }; +&cpsw_mac_syscon { + bootph-all; +}; + +&phy_gmii_sel { + bootph-all; +}; + &main_gpio0 { status = "okay"; pinctrl-names = "default"; @@ -626,6 +636,7 @@ &mcu_cpsw { &davinci_mdio { phy0: ethernet-phy@0 { reg = <0>; + bootph-all; ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>; ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>; ti,min-output-impedance; @@ -635,6 +646,7 @@ phy0: ethernet-phy@0 { &cpsw_port1 { phy-mode = "rgmii-rxid"; phy-handle = <&phy0>; + bootph-all; }; &mcu_mcan0 { -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v4 2/2] arm64: dts: ti: k3-am62p*/k3-j722s: Add bootph-all property to enable Ethernet boot 2025-04-29 7:26 [PATCH v4 0/2] Add bootph-all property to necessary nodes to enable ethernet boot for AM68-SK, J722s and AM62p-SK Chintan Vankar 2025-04-29 7:26 ` [PATCH v4 1/2] arm64: dts: ti: k3-am68-sk-base-board: Add bootph-all property to enable Ethernet boot Chintan Vankar @ 2025-04-29 7:26 ` Chintan Vankar 2025-04-29 11:27 ` Nishanth Menon 1 sibling, 1 reply; 6+ messages in thread From: Chintan Vankar @ 2025-04-29 7:26 UTC (permalink / raw) To: Conor Dooley, Krzysztof Kozlowski, Rob Herring, Tero Kristo, Vignesh Raghavendra, Nishanth Menon Cc: srk, s-vadapalli, danishanwar, c-vankar, linux-kernel, devicetree, linux-arm-kernel, Roger Quadros Ethernet boot requires CPSW nodes to be present starting from R5 SPL stage. Add bootph-all property to required nodes to enable Ethernet boot for AM62P5-SK and J722S-EVM. Reviewed-by: Roger Quadros <rogerq@kernel.org> Signed-off-by: Chintan Vankar <c-vankar@ti.com> --- Link to v3: https://lore.kernel.org/r/20250425051055.2393301-3-c-vankar@ti.com/ Changes from v3 to v4: - No changes. arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 3 +++ arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 2 ++ arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 3 +++ 3 files changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi index 7b65538110e8..11f484f88603 100644 --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi @@ -50,6 +50,7 @@ phy_gmii_sel: phy@4044 { compatible = "ti,am654-phy-gmii-sel"; reg = <0x4044 0x8>; #phy-cells = <1>; + bootph-all; }; epwm_tbclk: clock-controller@4130 { @@ -730,6 +731,7 @@ cpsw_port1: port@1 { mac-address = [00 00 00 00 00 00]; ti,syscon-efuse = <&cpsw_mac_syscon 0x0>; status = "disabled"; + bootph-all; }; cpsw_port2: port@2 { @@ -751,6 +753,7 @@ cpsw3g_mdio: mdio@f00 { clock-names = "fck"; bus_freq = <1000000>; status = "disabled"; + bootph-all; }; cpts@3d000 { diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts index d29f524600af..5b2f0945a9eb 100644 --- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts +++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts @@ -227,6 +227,7 @@ main_mdio1_pins_default: main-mdio1-default-pins { AM62PX_IOPAD(0x0160, PIN_OUTPUT, 0) /* (F17) MDIO0_MDC */ AM62PX_IOPAD(0x015c, PIN_INPUT, 0) /* (F16) MDIO0_MDIO */ >; + bootph-all; }; main_mmc1_pins_default: main-mmc1-default-pins { @@ -496,6 +497,7 @@ &cpsw3g_mdio { cpsw3g_phy0: ethernet-phy@0 { reg = <0>; + bootph-all; ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>; ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>; ti,min-output-impedance; diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts index 34b9d190800e..93d770c5792e 100644 --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts @@ -310,6 +310,7 @@ mdio_pins_default: mdio-default-pins { J722S_IOPAD(0x0160, PIN_OUTPUT, 0) /* (AC24) MDIO0_MDC */ J722S_IOPAD(0x015c, PIN_INPUT, 0) /* (AD25) MDIO0_MDIO */ >; + bootph-all; }; ospi0_pins_default: ospi0-default-pins { @@ -344,6 +345,7 @@ J722S_IOPAD(0x0140, PIN_OUTPUT, 0) /* (AF24) RGMII1_TD3 */ J722S_IOPAD(0x0130, PIN_OUTPUT, 0) /* (AG26) RGMII1_TXC */ J722S_IOPAD(0x012c, PIN_OUTPUT, 0) /* (AF25) RGMII1_TX_CTL */ >; + bootph-all; }; main_usb1_pins_default: main-usb1-default-pins { @@ -388,6 +390,7 @@ &cpsw3g_mdio { cpsw3g_phy0: ethernet-phy@0 { reg = <0>; + bootph-all; ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>; ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>; ti,min-output-impedance; -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v4 2/2] arm64: dts: ti: k3-am62p*/k3-j722s: Add bootph-all property to enable Ethernet boot 2025-04-29 7:26 ` [PATCH v4 2/2] arm64: dts: ti: k3-am62p*/k3-j722s: " Chintan Vankar @ 2025-04-29 11:27 ` Nishanth Menon 2025-04-30 5:48 ` Vankar, Chintan 0 siblings, 1 reply; 6+ messages in thread From: Nishanth Menon @ 2025-04-29 11:27 UTC (permalink / raw) To: Chintan Vankar Cc: Conor Dooley, Krzysztof Kozlowski, Rob Herring, Tero Kristo, Vignesh Raghavendra, srk, s-vadapalli, danishanwar, linux-kernel, devicetree, linux-arm-kernel, Roger Quadros On 12:56-20250429, Chintan Vankar wrote: > Ethernet boot requires CPSW nodes to be present starting from R5 SPL > stage. Add bootph-all property to required nodes to enable Ethernet boot > for AM62P5-SK and J722S-EVM. > > Reviewed-by: Roger Quadros <rogerq@kernel.org> > Signed-off-by: Chintan Vankar <c-vankar@ti.com> > --- > > Link to v3: > https://lore.kernel.org/r/20250425051055.2393301-3-c-vankar@ti.com/ > > Changes from v3 to v4: > - No changes. > > arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 3 +++ Please notice that we have the same problem[1] here as well. [1] https://lore.kernel.org/all/20250425212427.vvyocc4mmne5g3vq@vividly/ > arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 2 ++ > arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 3 +++ > 3 files changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi > index 7b65538110e8..11f484f88603 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi > @@ -50,6 +50,7 @@ phy_gmii_sel: phy@4044 { > compatible = "ti,am654-phy-gmii-sel"; > reg = <0x4044 0x8>; > #phy-cells = <1>; > + bootph-all; > }; > > epwm_tbclk: clock-controller@4130 { > @@ -730,6 +731,7 @@ cpsw_port1: port@1 { > mac-address = [00 00 00 00 00 00]; > ti,syscon-efuse = <&cpsw_mac_syscon 0x0>; > status = "disabled"; > + bootph-all; > }; > > cpsw_port2: port@2 { > @@ -751,6 +753,7 @@ cpsw3g_mdio: mdio@f00 { > clock-names = "fck"; > bus_freq = <1000000>; > status = "disabled"; > + bootph-all; > }; > > cpts@3d000 { > diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts > index d29f524600af..5b2f0945a9eb 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts > +++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts > @@ -227,6 +227,7 @@ main_mdio1_pins_default: main-mdio1-default-pins { > AM62PX_IOPAD(0x0160, PIN_OUTPUT, 0) /* (F17) MDIO0_MDC */ > AM62PX_IOPAD(0x015c, PIN_INPUT, 0) /* (F16) MDIO0_MDIO */ > >; > + bootph-all; > }; > > main_mmc1_pins_default: main-mmc1-default-pins { > @@ -496,6 +497,7 @@ &cpsw3g_mdio { > > cpsw3g_phy0: ethernet-phy@0 { > reg = <0>; > + bootph-all; > ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>; > ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>; > ti,min-output-impedance; > diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts > index 34b9d190800e..93d770c5792e 100644 > --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts > +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts > @@ -310,6 +310,7 @@ mdio_pins_default: mdio-default-pins { > J722S_IOPAD(0x0160, PIN_OUTPUT, 0) /* (AC24) MDIO0_MDC */ > J722S_IOPAD(0x015c, PIN_INPUT, 0) /* (AD25) MDIO0_MDIO */ > >; > + bootph-all; > }; > > ospi0_pins_default: ospi0-default-pins { > @@ -344,6 +345,7 @@ J722S_IOPAD(0x0140, PIN_OUTPUT, 0) /* (AF24) RGMII1_TD3 */ > J722S_IOPAD(0x0130, PIN_OUTPUT, 0) /* (AG26) RGMII1_TXC */ > J722S_IOPAD(0x012c, PIN_OUTPUT, 0) /* (AF25) RGMII1_TX_CTL */ > >; > + bootph-all; > }; > > main_usb1_pins_default: main-usb1-default-pins { > @@ -388,6 +390,7 @@ &cpsw3g_mdio { > > cpsw3g_phy0: ethernet-phy@0 { > reg = <0>; > + bootph-all; > ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>; > ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>; > ti,min-output-impedance; > -- > 2.34.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 2/2] arm64: dts: ti: k3-am62p*/k3-j722s: Add bootph-all property to enable Ethernet boot 2025-04-29 11:27 ` Nishanth Menon @ 2025-04-30 5:48 ` Vankar, Chintan 2025-05-02 12:00 ` Nishanth Menon 0 siblings, 1 reply; 6+ messages in thread From: Vankar, Chintan @ 2025-04-30 5:48 UTC (permalink / raw) To: Nishanth Menon Cc: Conor Dooley, Krzysztof Kozlowski, Rob Herring, Tero Kristo, Vignesh Raghavendra, srk, s-vadapalli, danishanwar, linux-kernel, devicetree, linux-arm-kernel, Roger Quadros Hello Nishanth, On 4/29/2025 4:57 PM, Nishanth Menon wrote: > On 12:56-20250429, Chintan Vankar wrote: >> Ethernet boot requires CPSW nodes to be present starting from R5 SPL >> stage. Add bootph-all property to required nodes to enable Ethernet boot >> for AM62P5-SK and J722S-EVM. >> >> Reviewed-by: Roger Quadros <rogerq@kernel.org> >> Signed-off-by: Chintan Vankar <c-vankar@ti.com> >> --- >> >> Link to v3: >> https://lore.kernel.org/r/20250425051055.2393301-3-c-vankar@ti.com/ >> >> Changes from v3 to v4: >> - No changes. >> >> arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 3 +++ > > Please notice that we have the same problem[1] here as well. > > [1] https://lore.kernel.org/all/20250425212427.vvyocc4mmne5g3vq@vividly/ I have added "bootph-all" property in the common file of J722S-EVM and AM62P5-SK since we are enabling Ethernet boot for both the boards. Are you referring to move the nodes I have added in "k3-am62p-j722s-common-main.dtsi" to respective board files, "k3-am62p5-sk.dts" and "k3-j722s-evm.dts". Regards, Chintan. > >> arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 2 ++ >> arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 3 +++ >> 3 files changed, 8 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi >> index 7b65538110e8..11f484f88603 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi >> @@ -50,6 +50,7 @@ phy_gmii_sel: phy@4044 { >> compatible = "ti,am654-phy-gmii-sel"; >> reg = <0x4044 0x8>; >> #phy-cells = <1>; >> + bootph-all; >> }; >> >> epwm_tbclk: clock-controller@4130 { >> @@ -730,6 +731,7 @@ cpsw_port1: port@1 { >> mac-address = [00 00 00 00 00 00]; >> ti,syscon-efuse = <&cpsw_mac_syscon 0x0>; >> status = "disabled"; >> + bootph-all; >> }; >> >> cpsw_port2: port@2 { >> @@ -751,6 +753,7 @@ cpsw3g_mdio: mdio@f00 { >> clock-names = "fck"; >> bus_freq = <1000000>; >> status = "disabled"; >> + bootph-all; >> }; >> >> cpts@3d000 { >> diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts >> index d29f524600af..5b2f0945a9eb 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts >> +++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts >> @@ -227,6 +227,7 @@ main_mdio1_pins_default: main-mdio1-default-pins { >> AM62PX_IOPAD(0x0160, PIN_OUTPUT, 0) /* (F17) MDIO0_MDC */ >> AM62PX_IOPAD(0x015c, PIN_INPUT, 0) /* (F16) MDIO0_MDIO */ >> >; >> + bootph-all; >> }; >> >> main_mmc1_pins_default: main-mmc1-default-pins { >> @@ -496,6 +497,7 @@ &cpsw3g_mdio { >> >> cpsw3g_phy0: ethernet-phy@0 { >> reg = <0>; >> + bootph-all; >> ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>; >> ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>; >> ti,min-output-impedance; >> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts >> index 34b9d190800e..93d770c5792e 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts >> +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts >> @@ -310,6 +310,7 @@ mdio_pins_default: mdio-default-pins { >> J722S_IOPAD(0x0160, PIN_OUTPUT, 0) /* (AC24) MDIO0_MDC */ >> J722S_IOPAD(0x015c, PIN_INPUT, 0) /* (AD25) MDIO0_MDIO */ >> >; >> + bootph-all; >> }; >> >> ospi0_pins_default: ospi0-default-pins { >> @@ -344,6 +345,7 @@ J722S_IOPAD(0x0140, PIN_OUTPUT, 0) /* (AF24) RGMII1_TD3 */ >> J722S_IOPAD(0x0130, PIN_OUTPUT, 0) /* (AG26) RGMII1_TXC */ >> J722S_IOPAD(0x012c, PIN_OUTPUT, 0) /* (AF25) RGMII1_TX_CTL */ >> >; >> + bootph-all; >> }; >> >> main_usb1_pins_default: main-usb1-default-pins { >> @@ -388,6 +390,7 @@ &cpsw3g_mdio { >> >> cpsw3g_phy0: ethernet-phy@0 { >> reg = <0>; >> + bootph-all; >> ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>; >> ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>; >> ti,min-output-impedance; >> -- >> 2.34.1 >> > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 2/2] arm64: dts: ti: k3-am62p*/k3-j722s: Add bootph-all property to enable Ethernet boot 2025-04-30 5:48 ` Vankar, Chintan @ 2025-05-02 12:00 ` Nishanth Menon 0 siblings, 0 replies; 6+ messages in thread From: Nishanth Menon @ 2025-05-02 12:00 UTC (permalink / raw) To: Vankar, Chintan Cc: Conor Dooley, Krzysztof Kozlowski, Rob Herring, Tero Kristo, Vignesh Raghavendra, srk, s-vadapalli, danishanwar, linux-kernel, devicetree, linux-arm-kernel, Roger Quadros On 11:18-20250430, Vankar, Chintan wrote: > Hello Nishanth, > > On 4/29/2025 4:57 PM, Nishanth Menon wrote: > > On 12:56-20250429, Chintan Vankar wrote: > > > Ethernet boot requires CPSW nodes to be present starting from R5 SPL > > > stage. Add bootph-all property to required nodes to enable Ethernet boot > > > for AM62P5-SK and J722S-EVM. > > > > > > Reviewed-by: Roger Quadros <rogerq@kernel.org> > > > Signed-off-by: Chintan Vankar <c-vankar@ti.com> > > > --- > > > > > > Link to v3: > > > https://lore.kernel.org/r/20250425051055.2393301-3-c-vankar@ti.com/ > > > > > > Changes from v3 to v4: > > > - No changes. > > > > > > arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 3 +++ > > > > Please notice that we have the same problem[1] here as well. > > > > [1] https://lore.kernel.org/all/20250425212427.vvyocc4mmne5g3vq@vividly/ > > I have added "bootph-all" property in the common file of J722S-EVM and > AM62P5-SK since we are enabling Ethernet boot for both the boards. Are > you referring to move the nodes I have added in > "k3-am62p-j722s-common-main.dtsi" to respective board files, > "k3-am62p5-sk.dts" and "k3-j722s-evm.dts". Yes, bootph properties should not be done in SoC dtsi files unless it is mandatory for all boot-modes and all boards. That is not the case here as well. This is the exact comment provided in the previous version for patch 1 with the expectation that you'd apply it to the rest of your series. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-05-02 12:01 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-04-29 7:26 [PATCH v4 0/2] Add bootph-all property to necessary nodes to enable ethernet boot for AM68-SK, J722s and AM62p-SK Chintan Vankar 2025-04-29 7:26 ` [PATCH v4 1/2] arm64: dts: ti: k3-am68-sk-base-board: Add bootph-all property to enable Ethernet boot Chintan Vankar 2025-04-29 7:26 ` [PATCH v4 2/2] arm64: dts: ti: k3-am62p*/k3-j722s: " Chintan Vankar 2025-04-29 11:27 ` Nishanth Menon 2025-04-30 5:48 ` Vankar, Chintan 2025-05-02 12:00 ` Nishanth Menon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox