The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] misc/vmw_vmci: Add dependency on CONFIG_NET
@ 2013-02-27 19:41 Guenter Roeck
  2013-03-08 20:36 ` Randy Dunlap
  0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2013-02-27 19:41 UTC (permalink / raw)
  To: linux-kernel
  Cc: Andy King, Greg Kroah-Hartman, Dmitry Torokhov, Guenter Roeck

Building the vmw_vmci driver with CONFIG_NET undefined results in:

drivers/built-in.o: In function `__qp_memcpy_from_queue.isra.13':
vmci_queue_pair.c:(.text+0x1671a8): undefined reference to `memcpy_toiovec'
drivers/built-in.o: In function `__qp_memcpy_to_queue.isra.14':
vmci_queue_pair.c:(.text+0x167341): undefined reference to `memcpy_fromiovec'
make[1]: [vmlinux] Error 1 (ignored)

since memcpy_toiovec and memcpy_fromiovec are defined in the networking code.
Add the missing dependency.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/misc/vmw_vmci/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/vmw_vmci/Kconfig b/drivers/misc/vmw_vmci/Kconfig
index 39c2eca..ea98f7e 100644
--- a/drivers/misc/vmw_vmci/Kconfig
+++ b/drivers/misc/vmw_vmci/Kconfig
@@ -4,7 +4,7 @@
 
 config VMWARE_VMCI
 	tristate "VMware VMCI Driver"
-	depends on X86 && PCI
+	depends on X86 && PCI && NET
 	help
 	  This is VMware's Virtual Machine Communication Interface.  It enables
 	  high-speed communication between host and guest in a virtual
-- 
1.7.9.7


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] misc/vmw_vmci: Add dependency on CONFIG_NET
  2013-02-27 19:41 [PATCH] misc/vmw_vmci: Add dependency on CONFIG_NET Guenter Roeck
@ 2013-03-08 20:36 ` Randy Dunlap
  0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2013-03-08 20:36 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: linux-kernel, Andy King, Greg Kroah-Hartman, Dmitry Torokhov

On 02/27/13 11:41, Guenter Roeck wrote:
> Building the vmw_vmci driver with CONFIG_NET undefined results in:
> 
> drivers/built-in.o: In function `__qp_memcpy_from_queue.isra.13':
> vmci_queue_pair.c:(.text+0x1671a8): undefined reference to `memcpy_toiovec'
> drivers/built-in.o: In function `__qp_memcpy_to_queue.isra.14':
> vmci_queue_pair.c:(.text+0x167341): undefined reference to `memcpy_fromiovec'
> make[1]: [vmlinux] Error 1 (ignored)
> 
> since memcpy_toiovec and memcpy_fromiovec are defined in the networking code.
> Add the missing dependency.
> 
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  drivers/misc/vmw_vmci/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/vmw_vmci/Kconfig b/drivers/misc/vmw_vmci/Kconfig
> index 39c2eca..ea98f7e 100644
> --- a/drivers/misc/vmw_vmci/Kconfig
> +++ b/drivers/misc/vmw_vmci/Kconfig
> @@ -4,7 +4,7 @@
>  
>  config VMWARE_VMCI
>  	tristate "VMware VMCI Driver"
> -	depends on X86 && PCI
> +	depends on X86 && PCI && NET
>  	help
>  	  This is VMware's Virtual Machine Communication Interface.  It enables
>  	  high-speed communication between host and guest in a virtual
> 


-- 
~Randy

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-03-08 20:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-27 19:41 [PATCH] misc/vmw_vmci: Add dependency on CONFIG_NET Guenter Roeck
2013-03-08 20:36 ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox