From: Arnd Bergmann <arnd@linaro.org>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: bskeggs@redhat.com, airlied@linux.ie,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn
Subject: Re: [PATCH] fix:overlay: add missing header dependencies
Date: Mon, 29 Aug 2016 12:41:18 +0200 [thread overview]
Message-ID: <5154334.AoCXYPCTSK@wuerfel> (raw)
In-Reply-To: <1472360572-28375-1-git-send-email-baoyou.xie@linaro.org>
On Sunday, August 28, 2016 1:02:52 PM CEST Baoyou Xie wrote:
> We get 1 warning when build kernel with W=1:
> drivers/gpu/drm/nouveau/dispnv04/overlay.c:496:1: warning: no previous prototype for 'nouveau_overlay_init' [-Wmissing-prototypes]
>
> In fact, this function is declared in disp.h, so this patch
> add missing header dependencies
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
a few general notes:
- please use my arnd@arndb.de address on patch submissions, not the linaro
address.
- for the email subject lines, have a look at what the typical style
is for the file. "overlay:" is not a good name here because it's not
unique to the driver, so better use "drm/nouveau", which will also
get the attention of the right people.
- please drop the "fix:" prefix in the subject.
Arnd
prev parent reply other threads:[~2016-08-29 10:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-28 5:02 [PATCH] fix:overlay: add missing header dependencies Baoyou Xie
2016-08-29 10:41 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5154334.AoCXYPCTSK@wuerfel \
--to=arnd@linaro.org \
--cc=airlied@linux.ie \
--cc=baoyou.xie@linaro.org \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox