From: Jonathan Cameron <jic23@kernel.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
linux-iio <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Naveen Krishna <naveenkrishna.ch@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH] iio: exynos_adc: fix wrong structure extration in suspend and resume
Date: Wed, 22 May 2013 22:16:04 +0100 [thread overview]
Message-ID: <519D3594.4070305@kernel.org> (raw)
In-Reply-To: <CAD=FV=Xppyb+Y0atygnwA8oBHmGHDx7Bit2fN12GX5Tt-Y9H1A@mail.gmail.com>
On 05/20/2013 06:09 PM, Doug Anderson wrote:
> Naveen,
>
> On Sun, May 19, 2013 at 11:34 PM, Naveen Krishna Chatradhi
> <ch.naveen@samsung.com> wrote:
>> The exynos_adc device structure was wrongly extracted from the dev*
>> correcting the same.
>>
>> Using the regular conversion of
>> struct device* -> struct platform_device* -> struct exynos_adc* seems wrong.
>> Instead we should be doing
>> struct device* -> struct iio_dev* -> struct exynos_adc*
>>
>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>> ---
>> drivers/iio/adc/exynos_adc.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
Applied to the fixes-togreg branch of iio.git
I'll hopefully send these on to Greg before the weekend.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-05-22 21:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 6:34 [PATCH] iio: exynos_adc: fix wrong structure extration in suspend and resume Naveen Krishna Chatradhi
2013-05-20 17:09 ` Doug Anderson
2013-05-22 21:16 ` Jonathan Cameron [this message]
2013-05-23 5:25 ` Naveen Krishna Ch
2013-08-28 5:33 ` Naveen Krishna Ch
2013-08-28 15:40 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519D3594.4070305@kernel.org \
--to=jic23@kernel.org \
--cc=ch.naveen@samsung.com \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=naveenkrishna.ch@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox