* [PATCH] iio: exynos_adc: fix wrong structure extration in suspend and resume
@ 2013-05-20 6:34 Naveen Krishna Chatradhi
2013-05-20 17:09 ` Doug Anderson
0 siblings, 1 reply; 6+ messages in thread
From: Naveen Krishna Chatradhi @ 2013-05-20 6:34 UTC (permalink / raw)
To: linux-iio
Cc: linux-kernel, linux-samsung-soc, dianders, gregkh,
naveenkrishna.ch, lars
The exynos_adc device structure was wrongly extracted from the dev*
correcting the same.
Using the regular conversion of
struct device* -> struct platform_device* -> struct exynos_adc* seems wrong.
Instead we should be doing
struct device* -> struct iio_dev* -> struct exynos_adc*
Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
---
drivers/iio/adc/exynos_adc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
index a6c4df5..2347df5 100644
--- a/drivers/iio/adc/exynos_adc.c
+++ b/drivers/iio/adc/exynos_adc.c
@@ -403,8 +403,8 @@ static int exynos_adc_remove(struct platform_device *pdev)
#ifdef CONFIG_PM_SLEEP
static int exynos_adc_suspend(struct device *dev)
{
- struct platform_device *pdev = to_platform_device(dev);
- struct exynos_adc *info = platform_get_drvdata(pdev);
+ struct iio_dev *indio_dev = dev_get_drvdata(dev);
+ struct exynos_adc *info = iio_priv(indio_dev);
u32 con;
if (info->version == ADC_V2) {
@@ -426,8 +426,8 @@ static int exynos_adc_suspend(struct device *dev)
static int exynos_adc_resume(struct device *dev)
{
- struct platform_device *pdev = to_platform_device(dev);
- struct exynos_adc *info = platform_get_drvdata(pdev);
+ struct iio_dev *indio_dev = dev_get_drvdata(dev);
+ struct exynos_adc *info = iio_priv(indio_dev);
int ret;
ret = regulator_enable(info->vdd);
--
1.7.12.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] iio: exynos_adc: fix wrong structure extration in suspend and resume
2013-05-20 6:34 [PATCH] iio: exynos_adc: fix wrong structure extration in suspend and resume Naveen Krishna Chatradhi
@ 2013-05-20 17:09 ` Doug Anderson
2013-05-22 21:16 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Doug Anderson @ 2013-05-20 17:09 UTC (permalink / raw)
To: Naveen Krishna Chatradhi
Cc: linux-iio, linux-kernel@vger.kernel.org, linux-samsung-soc,
Greg Kroah-Hartman, Naveen Krishna, Lars-Peter Clausen
Naveen,
On Sun, May 19, 2013 at 11:34 PM, Naveen Krishna Chatradhi
<ch.naveen@samsung.com> wrote:
> The exynos_adc device structure was wrongly extracted from the dev*
> correcting the same.
>
> Using the regular conversion of
> struct device* -> struct platform_device* -> struct exynos_adc* seems wrong.
> Instead we should be doing
> struct device* -> struct iio_dev* -> struct exynos_adc*
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> ---
> drivers/iio/adc/exynos_adc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Doug Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iio: exynos_adc: fix wrong structure extration in suspend and resume
2013-05-20 17:09 ` Doug Anderson
@ 2013-05-22 21:16 ` Jonathan Cameron
2013-05-23 5:25 ` Naveen Krishna Ch
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Cameron @ 2013-05-22 21:16 UTC (permalink / raw)
To: Doug Anderson
Cc: Naveen Krishna Chatradhi, linux-iio, linux-kernel@vger.kernel.org,
linux-samsung-soc, Greg Kroah-Hartman, Naveen Krishna,
Lars-Peter Clausen
On 05/20/2013 06:09 PM, Doug Anderson wrote:
> Naveen,
>
> On Sun, May 19, 2013 at 11:34 PM, Naveen Krishna Chatradhi
> <ch.naveen@samsung.com> wrote:
>> The exynos_adc device structure was wrongly extracted from the dev*
>> correcting the same.
>>
>> Using the regular conversion of
>> struct device* -> struct platform_device* -> struct exynos_adc* seems wrong.
>> Instead we should be doing
>> struct device* -> struct iio_dev* -> struct exynos_adc*
>>
>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>> ---
>> drivers/iio/adc/exynos_adc.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
Applied to the fixes-togreg branch of iio.git
I'll hopefully send these on to Greg before the weekend.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iio: exynos_adc: fix wrong structure extration in suspend and resume
2013-05-22 21:16 ` Jonathan Cameron
@ 2013-05-23 5:25 ` Naveen Krishna Ch
2013-08-28 5:33 ` Naveen Krishna Ch
0 siblings, 1 reply; 6+ messages in thread
From: Naveen Krishna Ch @ 2013-05-23 5:25 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Doug Anderson, Naveen Krishna Chatradhi, linux-iio,
linux-kernel@vger.kernel.org, linux-samsung-soc,
Greg Kroah-Hartman, Lars-Peter Clausen
On 23 May 2013 02:46, Jonathan Cameron <jic23@kernel.org> wrote:
> On 05/20/2013 06:09 PM, Doug Anderson wrote:
>> Naveen,
>>
>> On Sun, May 19, 2013 at 11:34 PM, Naveen Krishna Chatradhi
>> <ch.naveen@samsung.com> wrote:
>>> The exynos_adc device structure was wrongly extracted from the dev*
>>> correcting the same.
>>>
>>> Using the regular conversion of
>>> struct device* -> struct platform_device* -> struct exynos_adc* seems wrong.
>>> Instead we should be doing
>>> struct device* -> struct iio_dev* -> struct exynos_adc*
>>>
>>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>>> ---
>>> drivers/iio/adc/exynos_adc.c | 8 ++++----
>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> Reviewed-by: Doug Anderson <dianders@chromium.org>
> Applied to the fixes-togreg branch of iio.git
> I'll hopefully send these on to Greg before the weekend.
Jonathan,
I would like to know any comments on
https://patchwork.kernel.org/patch/2513361/
Its been pending for a while now.
Thanks,
Naveen
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
--
Shine bright,
(: Nav :)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iio: exynos_adc: fix wrong structure extration in suspend and resume
2013-05-23 5:25 ` Naveen Krishna Ch
@ 2013-08-28 5:33 ` Naveen Krishna Ch
2013-08-28 15:40 ` Doug Anderson
0 siblings, 1 reply; 6+ messages in thread
From: Naveen Krishna Ch @ 2013-08-28 5:33 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Doug Anderson, Naveen Krishna Chatradhi, linux-iio,
linux-kernel@vger.kernel.org, linux-samsung-soc,
Greg Kroah-Hartman, Lars-Peter Clausen
On 23 May 2013 10:55, Naveen Krishna Ch <naveenkrishna.ch@gmail.com> wrote:
> On 23 May 2013 02:46, Jonathan Cameron <jic23@kernel.org> wrote:
>> On 05/20/2013 06:09 PM, Doug Anderson wrote:
>>> Naveen,
>>>
>>> On Sun, May 19, 2013 at 11:34 PM, Naveen Krishna Chatradhi
>>> <ch.naveen@samsung.com> wrote:
>>>> The exynos_adc device structure was wrongly extracted from the dev*
>>>> correcting the same.
>>>>
>>>> Using the regular conversion of
>>>> struct device* -> struct platform_device* -> struct exynos_adc* seems wrong.
>>>> Instead we should be doing
>>>> struct device* -> struct iio_dev* -> struct exynos_adc*
>>>>
>>>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>>>> ---
>>>> drivers/iio/adc/exynos_adc.c | 8 ++++----
>>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> Reviewed-by: Doug Anderson <dianders@chromium.org>
>> Applied to the fixes-togreg branch of iio.git
>> I'll hopefully send these on to Greg before the weekend.
> Jonathan,
>
> I would like to know any comments on
>
> https://patchwork.kernel.org/patch/2513361/
>
> Its been pending for a while now.
>
> Thanks,
> Naveen
Ping
Any comments please
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>
>
>
>
> --
> Shine bright,
> (: Nav :)
--
Shine bright,
(: Nav :)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iio: exynos_adc: fix wrong structure extration in suspend and resume
2013-08-28 5:33 ` Naveen Krishna Ch
@ 2013-08-28 15:40 ` Doug Anderson
0 siblings, 0 replies; 6+ messages in thread
From: Doug Anderson @ 2013-08-28 15:40 UTC (permalink / raw)
To: Naveen Krishna Ch
Cc: Jonathan Cameron, Naveen Krishna Chatradhi, linux-iio,
linux-kernel@vger.kernel.org, linux-samsung-soc,
Greg Kroah-Hartman, Lars-Peter Clausen
Naveen
On Tue, Aug 27, 2013 at 10:33 PM, Naveen Krishna Ch
<naveenkrishna.ch@gmail.com> wrote:
>> I would like to know any comments on
>>
>> https://patchwork.kernel.org/patch/2513361/
>>
>> Its been pending for a while now.
>>
>> Thanks,
>> Naveen
> Ping
> Any comments please
I assume you're asking for a ping for the _other_ patch (AKA: "Handle
timeout issues"), not the one you're replying to here.
Can you please just do a REPOST of the patch you'd like comments on?
-Doug
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-08-28 15:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-20 6:34 [PATCH] iio: exynos_adc: fix wrong structure extration in suspend and resume Naveen Krishna Chatradhi
2013-05-20 17:09 ` Doug Anderson
2013-05-22 21:16 ` Jonathan Cameron
2013-05-23 5:25 ` Naveen Krishna Ch
2013-08-28 5:33 ` Naveen Krishna Ch
2013-08-28 15:40 ` Doug Anderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox