public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2/2 v3] tracing/uprobes: Support soft-mode disabling
@ 2013-06-25  3:30 zhangwei(Jovi)
  2013-06-25 10:19 ` Masami Hiramatsu
  0 siblings, 1 reply; 2+ messages in thread
From: zhangwei(Jovi) @ 2013-06-25  3:30 UTC (permalink / raw)
  To: Steven Rostedt, Masami Hiramatsu, Oleg Nesterov
  Cc: Frederic Weisbecker, Ingo Molnar, Srikar Dronamraju,
	linux-kernel@vger.kernel.org

Support soft-mode disabling on uprobe-based dynamic events.
Soft-disabling is just ignoring recording if the soft disabled
flag is set.

Signed-off-by: zhangwei(Jovi) <jovi.zhangwe@huawei.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
---
 kernel/trace/trace_uprobe.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index dbbb4a9..d2da3ea 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -530,6 +530,9 @@ static void uprobe_trace_print(struct trace_uprobe *tu,

 	WARN_ON(call != ftrace_file->event_call);

+	if (test_bit(FTRACE_EVENT_FL_SOFT_DISABLED_BIT, &ftrace_file->flags))
+		return;
+
 	size = SIZEOF_TRACE_ENTRY(is_ret_probe(tu));
 	event = trace_event_buffer_lock_reserve(&buffer, ftrace_file,
 						call->event.type,
-- 
1.7.9.7



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/2 v3] tracing/uprobes: Support soft-mode disabling
  2013-06-25  3:30 [PATCH 2/2 v3] tracing/uprobes: Support soft-mode disabling zhangwei(Jovi)
@ 2013-06-25 10:19 ` Masami Hiramatsu
  0 siblings, 0 replies; 2+ messages in thread
From: Masami Hiramatsu @ 2013-06-25 10:19 UTC (permalink / raw)
  To: zhangwei(Jovi)
  Cc: Steven Rostedt, Oleg Nesterov, Frederic Weisbecker, Ingo Molnar,
	Srikar Dronamraju, linux-kernel@vger.kernel.org,
	yrl.pp-manager.tt@hitachi.com

(2013/06/25 12:30), zhangwei(Jovi) wrote:
> Support soft-mode disabling on uprobe-based dynamic events.
> Soft-disabling is just ignoring recording if the soft disabled
> flag is set.
> 
> Signed-off-by: zhangwei(Jovi) <jovi.zhangwe@huawei.com>

Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

Thank you!

> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> ---
>  kernel/trace/trace_uprobe.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index dbbb4a9..d2da3ea 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -530,6 +530,9 @@ static void uprobe_trace_print(struct trace_uprobe *tu,
> 
>  	WARN_ON(call != ftrace_file->event_call);
> 
> +	if (test_bit(FTRACE_EVENT_FL_SOFT_DISABLED_BIT, &ftrace_file->flags))
> +		return;
> +
>  	size = SIZEOF_TRACE_ENTRY(is_ret_probe(tu));
>  	event = trace_event_buffer_lock_reserve(&buffer, ftrace_file,
>  						call->event.type,
> 


-- 
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-06-25 10:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-25  3:30 [PATCH 2/2 v3] tracing/uprobes: Support soft-mode disabling zhangwei(Jovi)
2013-06-25 10:19 ` Masami Hiramatsu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox