public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Horia Geantă" <horia.geanta@freescale.com>
To: Cristian Stoica <cristian.stoica@freescale.com>
Cc: <herbert@gondor.hengli.com.au>, <davem@davemloft.net>,
	<linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: remove double execution of the same test suite
Date: Fri, 19 Jul 2013 09:48:47 +0300	[thread overview]
Message-ID: <51E8E14F.8080603@freescale.com> (raw)
In-Reply-To: <1374163027-17201-1-git-send-email-cristian.stoica@freescale.com>

On 7/18/2013 6:57 PM, Cristian Stoica wrote:
> This patch removes redundant execution of the same test suite in cases
> where alg and driver variables are the same (e.g. when alg_test is
> called from tcrypt_test)
>
> Signed-off-by: Cristian Stoica <cristian.stoica@freescale.com>

Reviewed-by: Horia Geanta <horia.geanta@freescale.com>

> ---
>   crypto/testmgr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/testmgr.c b/crypto/testmgr.c
> index 2f00607..e091ef6 100644
> --- a/crypto/testmgr.c
> +++ b/crypto/testmgr.c
> @@ -3234,7 +3234,7 @@ int alg_test(const char *driver, const char *alg, u32 type, u32 mask)
>   	if (i >= 0)
>   		rc |= alg_test_descs[i].test(alg_test_descs + i, driver,
>   					     type, mask);
> -	if (j >= 0)
> +	if (j >= 0 && j != i)
>   		rc |= alg_test_descs[j].test(alg_test_descs + j, driver,
>   					     type, mask);
>
>




  reply	other threads:[~2013-07-19  6:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-18 15:57 [PATCH] crypto: remove double execution of the same test suite Cristian Stoica
2013-07-19  6:48 ` Horia Geantă [this message]
2013-07-19  6:52 ` Gupta Ruchika-R66431
2013-08-01  0:47 ` Herbert Xu
2013-08-01  8:11   ` Stoica Cristian-B18196
2013-08-01 11:37     ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E8E14F.8080603@freescale.com \
    --to=horia.geanta@freescale.com \
    --cc=cristian.stoica@freescale.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.hengli.com.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox