* Re: [PATCH v2 1/1 resend] i2c: rcar: modify I2C driver [not found] ` <1375687174-577-2-git-send-email-nv-dung@jinso.co.jp> @ 2013-08-07 15:12 ` Wolfram Sang [not found] ` <5202F0AC.4070609@jinso.co.jp> 0 siblings, 1 reply; 3+ messages in thread From: Wolfram Sang @ 2013-08-07 15:12 UTC (permalink / raw) To: Nguyen Viet Dung; +Cc: linux-i2c, linux-kernel, kuninori.morimoto.gx [-- Attachment #1: Type: text/plain, Size: 363 bytes --] On Mon, Aug 05, 2013 at 04:19:34PM +0900, Nguyen Viet Dung wrote: > This patch modify I2C driver of rcar-H1 to usable on both rcar-H1 and rcar-H2. > > Signed-off-by: Nguyen Viet Dung <nv-dung@jinso.co.jp> Isn't it possible to distinguish between H1 and H2 somewhere in hardware? Then we could skip the 'flags' variable in pdata. Thanks, Wolfram [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <5202F0AC.4070609@jinso.co.jp>]
* Re: [PATCH v2 1/1 resend] i2c: rcar: modify I2C driver [not found] ` <5202F0AC.4070609@jinso.co.jp> @ 2013-08-08 8:12 ` Wolfram Sang 2013-08-08 11:39 ` Nguyen Viet Dung 0 siblings, 1 reply; 3+ messages in thread From: Wolfram Sang @ 2013-08-08 8:12 UTC (permalink / raw) To: Nguyen Viet Dung; +Cc: linux-i2c, linux-kernel, kuninori.morimoto.gx On Thu, Aug 08, 2013 at 10:13:16AM +0900, Nguyen Viet Dung wrote: > Difference between H2 and H1 in hardware is only CDF bit of ICCCR register. No IP version register? Sigh... > If this method is not a common method, please tell me about common method. Use a new platform_device_id and populate the driver_data with the info needed to distinguish between the revisions. Check i2c-imx.c for an example. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1 resend] i2c: rcar: modify I2C driver 2013-08-08 8:12 ` Wolfram Sang @ 2013-08-08 11:39 ` Nguyen Viet Dung 0 siblings, 0 replies; 3+ messages in thread From: Nguyen Viet Dung @ 2013-08-08 11:39 UTC (permalink / raw) To: Wolfram Sang; +Cc: linux-i2c, linux-kernel, kuninori.morimoto.gx Hi Wolffam Thank for your advice. I have understand what you have guided. Time of 08/10~08/18 day is summer holiday in Japan. Affter summer holiday, I am going modify the patch, and send again. At that time,please check it for me. Thanks, Dung On 08/08/2013 05:12 PM, Wolfram Sang wrote: > On Thu, Aug 08, 2013 at 10:13:16AM +0900, Nguyen Viet Dung wrote: > >> Difference between H2 and H1 in hardware is only CDF bit of ICCCR register. > No IP version register? Sigh... > >> If this method is not a common method, please tell me about common method. > Use a new platform_device_id and populate the driver_data with the info > needed to distinguish between the revisions. Check i2c-imx.c for an > example. > > > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-08 11:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1375687174-577-1-git-send-email-nv-dung@jinso.co.jp>
[not found] ` <1375687174-577-2-git-send-email-nv-dung@jinso.co.jp>
2013-08-07 15:12 ` [PATCH v2 1/1 resend] i2c: rcar: modify I2C driver Wolfram Sang
[not found] ` <5202F0AC.4070609@jinso.co.jp>
2013-08-08 8:12 ` Wolfram Sang
2013-08-08 11:39 ` Nguyen Viet Dung
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox