[PATCH] staging/lustre: Make nrs_policy_get_info_locked() static

[PATCH] staging/lustre: Make nrs_policy_get_info_locked() static

[Rocco Folino]

This patch fixes the warning generated by sparse: "symbol 'nrs_policy_get_info_locked' was not
declared. Should it be static?" by declaring the function static.

Signed-off-by: Rocco Folino <rocco@devzen.net>
---
 drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c b/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
index 3a212b4be9a1..6cf9b92c7c05 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
@@ -452,7 +452,7 @@ static const char *nrs_state2str(enum ptlrpc_nrs_pol_state state)
  * \param[in] policy The policy
  * \param[out] info  Holds returned status information
  */
-void nrs_policy_get_info_locked(struct ptlrpc_nrs_policy *policy,
+static void nrs_policy_get_info_locked(struct ptlrpc_nrs_policy *policy,
 				struct ptlrpc_nrs_pol_info *info)
 {
 	LASSERT(policy != NULL);
--
2.4.3

Re: [PATCH] staging/lustre: Make nrs_policy_get_info_locked() static

[Arnd Bergmann]

On Friday 02 October 2015 23:54:26 Rocco Folino wrote:
> This patch fixes the warning generated by sparse: "symbol 'nrs_policy_get_info_locked' was not
> declared. Should it be static?" by declaring the function static.
> 
> Signed-off-by: Rocco Folino <rocco@devzen.net>
> 

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

This probably triggered a sparse warning after the unused declaration was
removed in my "staging/lustre: remove lots of dead code".

Re: [PATCH] staging/lustre: Make nrs_policy_get_info_locked() static

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1766 bytes --]

Hi Rocco,

[auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore]

config: sparc64-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sparc64 

All error/warnings (new ones prefixed by >>):

>> drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c:456:13: error: static declaration of 'nrs_policy_get_info_locked' follows non-static declaration
    static void nrs_policy_get_info_locked(struct ptlrpc_nrs_policy *policy,
                ^
   In file included from drivers/staging/lustre/lustre/ptlrpc/../include/lustre_lib.h:64:0,
                    from drivers/staging/lustre/lustre/ptlrpc/../include/obd.h:52,
                    from drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c:40:
   drivers/staging/lustre/lustre/ptlrpc/../include/lustre_net.h:1542:6: note: previous declaration of 'nrs_policy_get_info_locked' was here
    void nrs_policy_get_info_locked(struct ptlrpc_nrs_policy *policy,
         ^

vim +/nrs_policy_get_info_locked +456 drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c

   450	 *
   451	 * Information is copied in \a info.
   452	 *
   453	 * \param[in] policy The policy
   454	 * \param[out] info  Holds returned status information
   455	 */
 > 456	static void nrs_policy_get_info_locked(struct ptlrpc_nrs_policy *policy,
   457					struct ptlrpc_nrs_pol_info *info)
   458	{
   459		LASSERT(policy != NULL);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 43733 bytes --]

Re: [PATCH] staging/lustre: Make nrs_policy_get_info_locked() static

[Arnd Bergmann]

On Saturday 03 October 2015 06:10:12 kbuild test robot wrote:
> >> drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c:456:13: error: static declaration of 'nrs_policy_get_info_locked' follows non-static declaration
>     static void nrs_policy_get_info_locked(struct ptlrpc_nrs_policy *policy,
>                 ^
>    In file included from drivers/staging/lustre/lustre/ptlrpc/../include/lustre_lib.h:64:0,
>                     from drivers/staging/lustre/lustre/ptlrpc/../include/obd.h:52,
>                     from drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c:40:
>    drivers/staging/lustre/lustre/ptlrpc/../include/lustre_net.h:1542:6: note: previous declaration of 'nrs_policy_get_info_locked' was here
>     void nrs_policy_get_info_locked(struct ptlrpc_nrs_policy *policy,
>          ^
> 

fwiw, the patch should be fine on staging-testing, just not on mainline at the moment.

	Arnd