public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH V2] extcon: use dev_get_platdata()
@ 2013-09-11  3:08 Jingoo Han
  2013-09-11  4:29 ` Chanwoo Choi
  0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-09-11  3:08 UTC (permalink / raw)
  To: 'Chanwoo Choi'
  Cc: 'MyungJoo Ham', linux-kernel, 'Jingoo Han',
	'Anish Kumar', 'Lars-Peter Clausen',
	'Mike Lockwood', 'Laxman Dewangan',
	'Graeme Gregory'

Use the wrapper function for retrieving the platform data instead of
accessing dev->platform_data directly. This is a cosmetic change
to make the code simpler and enhance the readability.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
Changes since v2:
- squashed 3 patches into a single patch

 drivers/extcon/extcon-adc-jack.c |    2 +-
 drivers/extcon/extcon-gpio.c     |    2 +-
 drivers/extcon/extcon-palmas.c   |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/extcon/extcon-adc-jack.c b/drivers/extcon/extcon-adc-jack.c
index 5985807..c0e0e20 100644
--- a/drivers/extcon/extcon-adc-jack.c
+++ b/drivers/extcon/extcon-adc-jack.c
@@ -95,7 +95,7 @@ static irqreturn_t adc_jack_irq_thread(int irq, void *_data)
 static int adc_jack_probe(struct platform_device *pdev)
 {
 	struct adc_jack_data *data;
-	struct adc_jack_pdata *pdata = pdev->dev.platform_data;
+	struct adc_jack_pdata *pdata = dev_get_platdata(&pdev->dev);
 	int i, err = 0;
 
 	data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c
index f874c30..c4d5a19 100644
--- a/drivers/extcon/extcon-gpio.c
+++ b/drivers/extcon/extcon-gpio.c
@@ -78,7 +78,7 @@ static ssize_t extcon_gpio_print_state(struct extcon_dev *edev, char *buf)
 
 static int gpio_extcon_probe(struct platform_device *pdev)
 {
-	struct gpio_extcon_platform_data *pdata = pdev->dev.platform_data;
+	struct gpio_extcon_platform_data *pdata = dev_get_platdata(&pdev->dev);
 	struct gpio_extcon_data *extcon_data;
 	int ret = 0;
 
diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
index 89fdd05..0c2fb68 100644
--- a/drivers/extcon/extcon-palmas.c
+++ b/drivers/extcon/extcon-palmas.c
@@ -135,7 +135,7 @@ static void palmas_enable_irq(struct palmas_usb *palmas_usb)
 static int palmas_usb_probe(struct platform_device *pdev)
 {
 	struct palmas *palmas = dev_get_drvdata(pdev->dev.parent);
-	struct palmas_usb_platform_data	*pdata = pdev->dev.platform_data;
+	struct palmas_usb_platform_data	*pdata = dev_get_platdata(&pdev->dev);
 	struct device_node *node = pdev->dev.of_node;
 	struct palmas_usb *palmas_usb;
 	int status;
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH V2] extcon: use dev_get_platdata()
  2013-09-11  3:08 [PATCH V2] extcon: use dev_get_platdata() Jingoo Han
@ 2013-09-11  4:29 ` Chanwoo Choi
  0 siblings, 0 replies; 2+ messages in thread
From: Chanwoo Choi @ 2013-09-11  4:29 UTC (permalink / raw)
  To: Jingoo Han
  Cc: 'MyungJoo Ham', linux-kernel, 'Anish Kumar',
	'Lars-Peter Clausen', 'Mike Lockwood',
	'Laxman Dewangan', 'Graeme Gregory'

On 09/11/2013 12:08 PM, Jingoo Han wrote:
> Use the wrapper function for retrieving the platform data instead of
> accessing dev->platform_data directly. This is a cosmetic change
> to make the code simpler and enhance the readability.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> Changes since v2:
> - squashed 3 patches into a single patch
> 
>  drivers/extcon/extcon-adc-jack.c |    2 +-
>  drivers/extcon/extcon-gpio.c     |    2 +-
>  drivers/extcon/extcon-palmas.c   |    2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 

Applied it on extcon-linus branch.

Thanks,
Chanwoo Choi


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-09-11  4:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-11  3:08 [PATCH V2] extcon: use dev_get_platdata() Jingoo Han
2013-09-11  4:29 ` Chanwoo Choi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox