Re: [PATCH 08/16] staging/lustre/mdt: HSM coordinator agent interface

[Peng Tao <bergwolf@gmail.com>]

On 11/26/2013 11:30 AM, Greg Kroah-Hartman wrote:
> On Tue, Nov 26, 2013 at 10:05:02AM +0800, Peng Tao wrote:
>> From: JC Lafoucriere <jacques-charles.lafoucriere@cea.fr>
>>
>> To move data with external storage, HSM coordinator
>> uses a Copy Tool running on a client named agent.
>> This patch implements the interface for these agents.
>
> Interesting text here...
>
>> Lustre-change: http://review.whamcloud.com/6534
>> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3342
>> Signed-off-by: JC Lafoucriere <jacques-charles.lafoucriere@cea.fr>
>> Reviewed-by: Jinshan Xiong <jinshan.xiong@intel.com>
>> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
>> Reviewed-by: John L. Hammond <john.hammond@intel.com>
>> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
>> Signed-off-by: Peng Tao <bergwolf@gmail.com>
>> Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
>> ---
>>   .../lustre/lustre/include/lustre/lustre_user.h     |    6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
>> index 9436166..631f026 100644
>> --- a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
>> +++ b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
>> @@ -428,8 +428,8 @@ struct obd_uuid {
>>   	char uuid[UUID_MAX];
>>   };
>>
>> -static inline int obd_uuid_equals(const struct obd_uuid *u1,
>> -				  const struct obd_uuid *u2)
>> +static inline bool obd_uuid_equals(const struct obd_uuid *u1,
>> +				   const struct obd_uuid *u2)
>>   {
>>   	return strcmp((char *)u1->uuid, (char *)u2->uuid) == 0;
>>   }
>> @@ -446,7 +446,7 @@ static inline void obd_str2uuid(struct obd_uuid *uuid, const char *tmp)
>>   }
>>
>>   /* For printf's only, make sure uuid is terminated */
>> -static inline char *obd_uuid2str(struct obd_uuid *uuid)
>> +static inline char *obd_uuid2str(const struct obd_uuid *uuid)
>>   {
>>   	if (uuid->uuid[sizeof(*uuid) - 1] != '\0') {
>>   		/* Obviously not safe, but for printfs, no real harm done...
>
> Too bad it doesn't describe the changes made in the code at all.
>
> How can so many people review a patch that is not the same as what it
> says it really is?
>
The main part of the original commit is dropped as it only touches 
server code. I should have modified the commit message to say what 
exactly the patch does rather than just copying the original commit 
message. I'll fix up. Sorry.

> I'm stopping here in the series, sorry.  Please fix up and resend the
> rest when you can.
>
Will do. Thanks for reviewing!

Thanks,
Tao