* [PATCH] ACPI / init: Run acpi_early_init() before timekeeping_init()
@ 2014-01-15 7:25 Lee, Chun-Yi
2014-01-15 12:16 ` H. Peter Anvin
0 siblings, 1 reply; 3+ messages in thread
From: Lee, Chun-Yi @ 2014-01-15 7:25 UTC (permalink / raw)
To: Rafael J. Wysocki, Alessandro Zummo, H. Peter Anvin, Matt Fleming,
Matthew Garrett
Cc: Elliott, samer.el-haj-mahmoud, Oliver Neukum, werner, trenn,
JBeulich, linux-kernel, rtc-linux, x86, linux-efi@vger.kernel.org,
linux-acpi, Lee, Chun-Yi, Rafael J. Wysocki, Matt Fleming,
H. Peter Anvin, Borislav Petkov, Matthew Garrett
This is a variant patch from Rafael J. Wysocki's
ACPI / init: Run acpi_early_init() before efi_enter_virtual_mode()
According to Matt Fleming, if acpi_early_init() was executed before
efi_enter_virtual_mode(), the EFI initialization could benefit from
it, so Rafael's patch makes that happen.
And, we want accessing ACPI TAD device to set system clock, so move
acpi_early_init() before timekeeping_init(). This final position is
also before efi_enter_virtual_mode().
v2:
Move acpi_early_init() before timekeeping_init() to prepare setting
system clock with ACPI TAD.
v1:
Rafael J. Wysocki
ACPI / init: Run acpi_early_init() before efi_enter_virtual_mode()
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Matt Fleming <matt@console-pimps.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: Matthew Garrett <matthew.garrett@nebula.com>
Tested-by: Toshi Kani <toshi.kani@hp.com>
Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
---
init/main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/init/main.c b/init/main.c
index febc511..b6d93c8 100644
--- a/init/main.c
+++ b/init/main.c
@@ -565,6 +565,7 @@ asmlinkage void __init start_kernel(void)
init_timers();
hrtimers_init();
softirq_init();
+ acpi_early_init();
timekeeping_init();
time_init();
sched_clock_postinit();
@@ -641,7 +642,6 @@ asmlinkage void __init start_kernel(void)
check_bugs();
- acpi_early_init(); /* before LAPIC and SMP init */
sfi_init_late();
if (efi_enabled(EFI_RUNTIME_SERVICES)) {
--
1.6.4.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ACPI / init: Run acpi_early_init() before timekeeping_init()
2014-01-15 7:25 [PATCH] ACPI / init: Run acpi_early_init() before timekeeping_init() Lee, Chun-Yi
@ 2014-01-15 12:16 ` H. Peter Anvin
2014-01-15 13:24 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: H. Peter Anvin @ 2014-01-15 12:16 UTC (permalink / raw)
To: Lee, Chun-Yi, Rafael J. Wysocki, Alessandro Zummo, Matt Fleming,
Matthew Garrett
Cc: Elliott, samer.el-haj-mahmoud, Oliver Neukum, werner, trenn,
JBeulich, linux-kernel, rtc-linux, x86, linux-efi@vger.kernel.org,
linux-acpi, Lee, Chun-Yi, Borislav Petkov
Rafael, you want to take this one?
On 01/14/2014 11:25 PM, Lee, Chun-Yi wrote:
> This is a variant patch from Rafael J. Wysocki's
> ACPI / init: Run acpi_early_init() before efi_enter_virtual_mode()
>
> According to Matt Fleming, if acpi_early_init() was executed before
> efi_enter_virtual_mode(), the EFI initialization could benefit from
> it, so Rafael's patch makes that happen.
>
> And, we want accessing ACPI TAD device to set system clock, so move
> acpi_early_init() before timekeeping_init(). This final position is
> also before efi_enter_virtual_mode().
>
> v2:
> Move acpi_early_init() before timekeeping_init() to prepare setting
> system clock with ACPI TAD.
>
> v1:
> Rafael J. Wysocki
> ACPI / init: Run acpi_early_init() before efi_enter_virtual_mode()
>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> Cc: Matt Fleming <matt@console-pimps.org>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Matthew Garrett <matthew.garrett@nebula.com>
> Tested-by: Toshi Kani <toshi.kani@hp.com>
> Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
> ---
> init/main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/init/main.c b/init/main.c
> index febc511..b6d93c8 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -565,6 +565,7 @@ asmlinkage void __init start_kernel(void)
> init_timers();
> hrtimers_init();
> softirq_init();
> + acpi_early_init();
> timekeeping_init();
> time_init();
> sched_clock_postinit();
> @@ -641,7 +642,6 @@ asmlinkage void __init start_kernel(void)
>
> check_bugs();
>
> - acpi_early_init(); /* before LAPIC and SMP init */
> sfi_init_late();
>
> if (efi_enabled(EFI_RUNTIME_SERVICES)) {
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ACPI / init: Run acpi_early_init() before timekeeping_init()
2014-01-15 12:16 ` H. Peter Anvin
@ 2014-01-15 13:24 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2014-01-15 13:24 UTC (permalink / raw)
To: H. Peter Anvin
Cc: Lee, Chun-Yi, Alessandro Zummo, Matt Fleming, Matthew Garrett,
Elliott, samer.el-haj-mahmoud, Oliver Neukum, werner, trenn,
JBeulich, linux-kernel, rtc-linux, x86, linux-efi@vger.kernel.org,
linux-acpi, Lee, Chun-Yi, Borislav Petkov
On Wednesday, January 15, 2014 04:16:59 AM H. Peter Anvin wrote:
> Rafael, you want to take this one?
Yes, I can take it.
Thanks!
> On 01/14/2014 11:25 PM, Lee, Chun-Yi wrote:
> > This is a variant patch from Rafael J. Wysocki's
> > ACPI / init: Run acpi_early_init() before efi_enter_virtual_mode()
> >
> > According to Matt Fleming, if acpi_early_init() was executed before
> > efi_enter_virtual_mode(), the EFI initialization could benefit from
> > it, so Rafael's patch makes that happen.
> >
> > And, we want accessing ACPI TAD device to set system clock, so move
> > acpi_early_init() before timekeeping_init(). This final position is
> > also before efi_enter_virtual_mode().
> >
> > v2:
> > Move acpi_early_init() before timekeeping_init() to prepare setting
> > system clock with ACPI TAD.
> >
> > v1:
> > Rafael J. Wysocki
> > ACPI / init: Run acpi_early_init() before efi_enter_virtual_mode()
> >
> > Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> > Cc: Matt Fleming <matt@console-pimps.org>
> > Cc: H. Peter Anvin <hpa@zytor.com>
> > Cc: Borislav Petkov <bp@suse.de>
> > Cc: Matthew Garrett <matthew.garrett@nebula.com>
> > Tested-by: Toshi Kani <toshi.kani@hp.com>
> > Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
> > ---
> > init/main.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/init/main.c b/init/main.c
> > index febc511..b6d93c8 100644
> > --- a/init/main.c
> > +++ b/init/main.c
> > @@ -565,6 +565,7 @@ asmlinkage void __init start_kernel(void)
> > init_timers();
> > hrtimers_init();
> > softirq_init();
> > + acpi_early_init();
> > timekeeping_init();
> > time_init();
> > sched_clock_postinit();
> > @@ -641,7 +642,6 @@ asmlinkage void __init start_kernel(void)
> >
> > check_bugs();
> >
> > - acpi_early_init(); /* before LAPIC and SMP init */
> > sfi_init_late();
> >
> > if (efi_enabled(EFI_RUNTIME_SERVICES)) {
> >
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-15 13:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-15 7:25 [PATCH] ACPI / init: Run acpi_early_init() before timekeeping_init() Lee, Chun-Yi
2014-01-15 12:16 ` H. Peter Anvin
2014-01-15 13:24 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox