From: Guenter Roeck <linux@roeck-us.net>
To: linux-c6x-dev@linux-c6x.org
Cc: linux-kernel@vger.kernel.org, Mark Salter <msalter@redhat.com>,
Aurelien Jacquiot <a-jacquiot@ti.com>,
Guenter Roeck <linux@roeck-us.net>, Joe Perches <joe@perches.com>
Subject: Re: [PATCH] c6x: Include init.h in asm/cache.h
Date: Sat, 15 Feb 2014 09:57:59 -0800 [thread overview]
Message-ID: <52FFAAA7.6040104@roeck-us.net> (raw)
In-Reply-To: <1391781742-32250-1-git-send-email-linux@roeck-us.net>
On 02/07/2014 06:02 AM, Guenter Roeck wrote:
> arch/c6x/include/asm/cache.h uses __init and thus needs to include init.h.
> This fixes the following c6x build error.
>
> arch/c6x/include/asm/cache.h:63:20: error: expected '=', ',', ';',
> 'asm' or '__attribute__' before 'c6x_cache_init'
> extern void __init c6x_cache_init(void);
>
> Problem was inadvertendly introduced with commit c28aa1f
> (printk/cache: mark printk_once test variable __read_mostly).
>
> Cc: Joe Perches <joe@perches.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> arch/c6x/include/asm/cache.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/c6x/include/asm/cache.h b/arch/c6x/include/asm/cache.h
> index 09c5a0f..86648c0 100644
> --- a/arch/c6x/include/asm/cache.h
> +++ b/arch/c6x/include/asm/cache.h
> @@ -12,6 +12,7 @@
> #define _ASM_C6X_CACHE_H
>
> #include <linux/irqflags.h>
> +#include <linux/init.h>
>
> /*
> * Cache line size
>
ping ... c6x builds still fail in mainline due to this problem.
Anyone interested in a fix ?
Guenter
next prev parent reply other threads:[~2014-02-15 17:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 14:02 [PATCH] c6x: Include init.h in asm/cache.h Guenter Roeck
2014-02-15 17:57 ` Guenter Roeck [this message]
2014-02-15 19:24 ` Mark Salter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FFAAA7.6040104@roeck-us.net \
--to=linux@roeck-us.net \
--cc=a-jacquiot@ti.com \
--cc=joe@perches.com \
--cc=linux-c6x-dev@linux-c6x.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msalter@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox