* [PATCH] c6x: Include init.h in asm/cache.h
@ 2014-02-07 14:02 Guenter Roeck
2014-02-15 17:57 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2014-02-07 14:02 UTC (permalink / raw)
To: linux-c6x-dev
Cc: linux-kernel, Mark Salter, Aurelien Jacquiot, Guenter Roeck,
Joe Perches
arch/c6x/include/asm/cache.h uses __init and thus needs to include init.h.
This fixes the following c6x build error.
arch/c6x/include/asm/cache.h:63:20: error: expected '=', ',', ';',
'asm' or '__attribute__' before 'c6x_cache_init'
extern void __init c6x_cache_init(void);
Problem was inadvertendly introduced with commit c28aa1f
(printk/cache: mark printk_once test variable __read_mostly).
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
arch/c6x/include/asm/cache.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/c6x/include/asm/cache.h b/arch/c6x/include/asm/cache.h
index 09c5a0f..86648c0 100644
--- a/arch/c6x/include/asm/cache.h
+++ b/arch/c6x/include/asm/cache.h
@@ -12,6 +12,7 @@
#define _ASM_C6X_CACHE_H
#include <linux/irqflags.h>
+#include <linux/init.h>
/*
* Cache line size
--
1.7.9.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] c6x: Include init.h in asm/cache.h
2014-02-07 14:02 [PATCH] c6x: Include init.h in asm/cache.h Guenter Roeck
@ 2014-02-15 17:57 ` Guenter Roeck
2014-02-15 19:24 ` Mark Salter
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2014-02-15 17:57 UTC (permalink / raw)
To: linux-c6x-dev
Cc: linux-kernel, Mark Salter, Aurelien Jacquiot, Guenter Roeck,
Joe Perches
On 02/07/2014 06:02 AM, Guenter Roeck wrote:
> arch/c6x/include/asm/cache.h uses __init and thus needs to include init.h.
> This fixes the following c6x build error.
>
> arch/c6x/include/asm/cache.h:63:20: error: expected '=', ',', ';',
> 'asm' or '__attribute__' before 'c6x_cache_init'
> extern void __init c6x_cache_init(void);
>
> Problem was inadvertendly introduced with commit c28aa1f
> (printk/cache: mark printk_once test variable __read_mostly).
>
> Cc: Joe Perches <joe@perches.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> arch/c6x/include/asm/cache.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/c6x/include/asm/cache.h b/arch/c6x/include/asm/cache.h
> index 09c5a0f..86648c0 100644
> --- a/arch/c6x/include/asm/cache.h
> +++ b/arch/c6x/include/asm/cache.h
> @@ -12,6 +12,7 @@
> #define _ASM_C6X_CACHE_H
>
> #include <linux/irqflags.h>
> +#include <linux/init.h>
>
> /*
> * Cache line size
>
ping ... c6x builds still fail in mainline due to this problem.
Anyone interested in a fix ?
Guenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] c6x: Include init.h in asm/cache.h
2014-02-15 17:57 ` Guenter Roeck
@ 2014-02-15 19:24 ` Mark Salter
0 siblings, 0 replies; 3+ messages in thread
From: Mark Salter @ 2014-02-15 19:24 UTC (permalink / raw)
To: Guenter Roeck; +Cc: linux-c6x-dev, linux-kernel, Aurelien Jacquiot, Joe Perches
On Sat, 2014-02-15 at 09:57 -0800, Guenter Roeck wrote:
> On 02/07/2014 06:02 AM, Guenter Roeck wrote:
> > arch/c6x/include/asm/cache.h uses __init and thus needs to include init.h.
> > This fixes the following c6x build error.
> >
> > arch/c6x/include/asm/cache.h:63:20: error: expected '=', ',', ';',
> > 'asm' or '__attribute__' before 'c6x_cache_init'
> > extern void __init c6x_cache_init(void);
> >
> > Problem was inadvertendly introduced with commit c28aa1f
> > (printk/cache: mark printk_once test variable __read_mostly).
> >
> > Cc: Joe Perches <joe@perches.com>
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> > arch/c6x/include/asm/cache.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/c6x/include/asm/cache.h b/arch/c6x/include/asm/cache.h
> > index 09c5a0f..86648c0 100644
> > --- a/arch/c6x/include/asm/cache.h
> > +++ b/arch/c6x/include/asm/cache.h
> > @@ -12,6 +12,7 @@
> > #define _ASM_C6X_CACHE_H
> >
> > #include <linux/irqflags.h>
> > +#include <linux/init.h>
> >
> > /*
> > * Cache line size
> >
>
> ping ... c6x builds still fail in mainline due to this problem.
> Anyone interested in a fix ?
>
Yes, I'm interested. A fix has been in linux-next for a while but I
haven't pushed it to Linus yet. Will do that this week.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-15 19:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-07 14:02 [PATCH] c6x: Include init.h in asm/cache.h Guenter Roeck
2014-02-15 17:57 ` Guenter Roeck
2014-02-15 19:24 ` Mark Salter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox