From: Prarit Bhargava <prarit@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-kernel@vger.kernel.org, Rui Wang <rui.y.wang@intel.com>,
Michel Lespinasse <walken@google.com>,
Seiji Aguchi <seiji.aguchi@hds.com>,
Yang Zhang <yang.z.zhang@intel.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
janet.morgan@intel.com, tony.luck@intel.com, ruiv.wang@gmail.com
Subject: Re: [PATCH] x86, apic, Fix missing replacement for VECTOR_UNDEFINED
Date: Wed, 05 Mar 2014 08:04:44 -0500 [thread overview]
Message-ID: <531720EC.7070301@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1403041436050.5421@chino.kir.corp.google.com>
On 03/04/2014 05:37 PM, David Rientjes wrote:
> On Tue, 4 Mar 2014, Prarit Bhargava wrote:
>
>> linux.git commit 9345005f4eed805308193658d12e4e7e9c261e74 added
>> a definition for VECTOR_UNDEFINED = -1. There is a missing replacement in
>> the io_apic.c file. Found during debugging of another issue.
>>
>> Cc: Rui Wang <rui.y.wang@intel.com>
>> Cc: Michel Lespinasse <walken@google.com>
>> Cc: Seiji Aguchi <seiji.aguchi@hds.com>
>> Cc: Yang Zhang <yang.z.zhang@Intel.com>
>> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
>> Cc: janet.morgan@Intel.com
>> Cc: tony.luck@Intel.com
>> Cc: ruiv.wang@gmail.com
>> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
>
> Acked-by: David Rientjes <rientjes@google.com>
>
> I think it would have been better to define VECTOR_UNDEFINED to be (-1)
> rather than -1, though, to ensure it can't be used erroneously as an
> arithmetic operation.
Good point David, I'll push a separate patch for your suggestion. As always,
thanks for acking :)
P.
next prev parent reply other threads:[~2014-03-05 13:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 14:27 [PATCH] x86, apic, Fix missing replacement for VECTOR_UNDEFINED Prarit Bhargava
2014-03-04 22:37 ` David Rientjes
2014-03-05 13:04 ` Prarit Bhargava [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-04-02 12:16 Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531720EC.7070301@redhat.com \
--to=prarit@redhat.com \
--cc=janet.morgan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rientjes@google.com \
--cc=rui.y.wang@intel.com \
--cc=ruiv.wang@gmail.com \
--cc=seiji.aguchi@hds.com \
--cc=tony.luck@intel.com \
--cc=walken@google.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox