* [PATCH] x86, apic, Fix missing replacement for VECTOR_UNDEFINED
@ 2014-03-04 14:27 Prarit Bhargava
2014-03-04 22:37 ` David Rientjes
0 siblings, 1 reply; 4+ messages in thread
From: Prarit Bhargava @ 2014-03-04 14:27 UTC (permalink / raw)
To: linux-kernel
Cc: Prarit Bhargava, Rui Wang, Michel Lespinasse, Seiji Aguchi,
Yang Zhang, Paul Gortmaker, janet.morgan, tony.luck, ruiv.wang
linux.git commit 9345005f4eed805308193658d12e4e7e9c261e74 added
a definition for VECTOR_UNDEFINED = -1. There is a missing replacement in
the io_apic.c file. Found during debugging of another issue.
Cc: Rui Wang <rui.y.wang@intel.com>
Cc: Michel Lespinasse <walken@google.com>
Cc: Seiji Aguchi <seiji.aguchi@hds.com>
Cc: Yang Zhang <yang.z.zhang@Intel.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: janet.morgan@Intel.com
Cc: tony.luck@Intel.com
Cc: ruiv.wang@gmail.com
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
---
arch/x86/kernel/apic/io_apic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 6ad4658..bf97b64 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -2240,7 +2240,7 @@ asmlinkage void smp_irq_move_cleanup_interrupt(void)
apic->send_IPI_self(IRQ_MOVE_CLEANUP_VECTOR);
goto unlock;
}
- __this_cpu_write(vector_irq[vector], -1);
+ __this_cpu_write(vector_irq[vector], VECTOR_UNDEFINED);
unlock:
raw_spin_unlock(&desc->lock);
}
--
1.7.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] x86, apic, Fix missing replacement for VECTOR_UNDEFINED
2014-03-04 14:27 [PATCH] x86, apic, Fix missing replacement for VECTOR_UNDEFINED Prarit Bhargava
@ 2014-03-04 22:37 ` David Rientjes
2014-03-05 13:04 ` Prarit Bhargava
0 siblings, 1 reply; 4+ messages in thread
From: David Rientjes @ 2014-03-04 22:37 UTC (permalink / raw)
To: Prarit Bhargava
Cc: linux-kernel, Rui Wang, Michel Lespinasse, Seiji Aguchi,
Yang Zhang, Paul Gortmaker, janet.morgan, tony.luck, ruiv.wang
On Tue, 4 Mar 2014, Prarit Bhargava wrote:
> linux.git commit 9345005f4eed805308193658d12e4e7e9c261e74 added
> a definition for VECTOR_UNDEFINED = -1. There is a missing replacement in
> the io_apic.c file. Found during debugging of another issue.
>
> Cc: Rui Wang <rui.y.wang@intel.com>
> Cc: Michel Lespinasse <walken@google.com>
> Cc: Seiji Aguchi <seiji.aguchi@hds.com>
> Cc: Yang Zhang <yang.z.zhang@Intel.com>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Cc: janet.morgan@Intel.com
> Cc: tony.luck@Intel.com
> Cc: ruiv.wang@gmail.com
> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Acked-by: David Rientjes <rientjes@google.com>
I think it would have been better to define VECTOR_UNDEFINED to be (-1)
rather than -1, though, to ensure it can't be used erroneously as an
arithmetic operation.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86, apic, Fix missing replacement for VECTOR_UNDEFINED
2014-03-04 22:37 ` David Rientjes
@ 2014-03-05 13:04 ` Prarit Bhargava
0 siblings, 0 replies; 4+ messages in thread
From: Prarit Bhargava @ 2014-03-05 13:04 UTC (permalink / raw)
To: David Rientjes
Cc: linux-kernel, Rui Wang, Michel Lespinasse, Seiji Aguchi,
Yang Zhang, Paul Gortmaker, janet.morgan, tony.luck, ruiv.wang
On 03/04/2014 05:37 PM, David Rientjes wrote:
> On Tue, 4 Mar 2014, Prarit Bhargava wrote:
>
>> linux.git commit 9345005f4eed805308193658d12e4e7e9c261e74 added
>> a definition for VECTOR_UNDEFINED = -1. There is a missing replacement in
>> the io_apic.c file. Found during debugging of another issue.
>>
>> Cc: Rui Wang <rui.y.wang@intel.com>
>> Cc: Michel Lespinasse <walken@google.com>
>> Cc: Seiji Aguchi <seiji.aguchi@hds.com>
>> Cc: Yang Zhang <yang.z.zhang@Intel.com>
>> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
>> Cc: janet.morgan@Intel.com
>> Cc: tony.luck@Intel.com
>> Cc: ruiv.wang@gmail.com
>> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
>
> Acked-by: David Rientjes <rientjes@google.com>
>
> I think it would have been better to define VECTOR_UNDEFINED to be (-1)
> rather than -1, though, to ensure it can't be used erroneously as an
> arithmetic operation.
Good point David, I'll push a separate patch for your suggestion. As always,
thanks for acking :)
P.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] x86, apic, Fix missing replacement for VECTOR_UNDEFINED
@ 2014-04-02 12:16 Prarit Bhargava
0 siblings, 0 replies; 4+ messages in thread
From: Prarit Bhargava @ 2014-04-02 12:16 UTC (permalink / raw)
To: linux-kernel
Cc: Prarit Bhargava, Rui Wang, Michel Lespinasse, Seiji Aguchi,
Yang Zhang, Paul Gortmaker, janet.morgan, tony.luck, ruiv.wang,
David Rientjes
Resending ... making sure this wasn't dropped for some reason.
Previously sent here: http://marc.info/?l=linux-kernel&m=139397268027681&w=2
P.
---8<---
linux.git commit 9345005f4eed805308193658d12e4e7e9c261e74 added
a definition for VECTOR_UNDEFINED = -1. There is a missing replacement in
the io_apic.c file. Found during debugging of another issue.
Cc: Rui Wang <rui.y.wang@intel.com>
Cc: Michel Lespinasse <walken@google.com>
Cc: Seiji Aguchi <seiji.aguchi@hds.com>
Cc: Yang Zhang <yang.z.zhang@Intel.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: janet.morgan@Intel.com
Cc: tony.luck@Intel.com
Cc: ruiv.wang@gmail.com
Cc: David Rientjes <rientjes@google.com>
Acked-by: David Rientjes <rientjes@google.com>
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
---
arch/x86/kernel/apic/io_apic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 6ad4658..bf97b64 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -2240,7 +2240,7 @@ asmlinkage void smp_irq_move_cleanup_interrupt(void)
apic->send_IPI_self(IRQ_MOVE_CLEANUP_VECTOR);
goto unlock;
}
- __this_cpu_write(vector_irq[vector], -1);
+ __this_cpu_write(vector_irq[vector], VECTOR_UNDEFINED);
unlock:
raw_spin_unlock(&desc->lock);
}
--
1.7.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-04-02 12:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-04 14:27 [PATCH] x86, apic, Fix missing replacement for VECTOR_UNDEFINED Prarit Bhargava
2014-03-04 22:37 ` David Rientjes
2014-03-05 13:04 ` Prarit Bhargava
-- strict thread matches above, loose matches on Subject: below --
2014-04-02 12:16 Prarit Bhargava
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox