* [PATCHv2] Checks for Null value in function *get_skub
@ 2014-06-16 15:03 Nicholas Krause
2014-06-16 15:04 ` Steve Wise
0 siblings, 1 reply; 2+ messages in thread
From: Nicholas Krause @ 2014-06-16 15:03 UTC (permalink / raw)
To: swise; +Cc: roland, sean.hefty, hal.rosenstock, linux-rdma, linux-kernel
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
drivers/infiniband/hw/cxgb4/cm.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index f9477e2..2d56983 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -340,15 +340,13 @@ static int status2errno(int status)
*/
static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t gfp)
{
if (skb && !skb_is_nonlinear(skb) && !skb_cloned(skb)) {
skb_trim(skb, 0);
skb_get(skb);
skb_reset_transport_header(skb);
} else {
+ if (!skb)
+ kfree(skb);
skb = alloc_skb(len, gfp);
}
t4_set_arp_err_handler(skb, NULL, NULL);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCHv2] Checks for Null value in function *get_skub
2014-06-16 15:03 [PATCHv2] Checks for Null value in function *get_skub Nicholas Krause
@ 2014-06-16 15:04 ` Steve Wise
0 siblings, 0 replies; 2+ messages in thread
From: Steve Wise @ 2014-06-16 15:04 UTC (permalink / raw)
To: Nicholas Krause, swise
Cc: roland, sean.hefty, hal.rosenstock, linux-rdma, linux-kernel
On 6/16/2014 10:03 AM, Nicholas Krause wrote:
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/infiniband/hw/cxgb4/cm.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
> index f9477e2..2d56983 100644
> --- a/drivers/infiniband/hw/cxgb4/cm.c
> +++ b/drivers/infiniband/hw/cxgb4/cm.c
> @@ -340,15 +340,13 @@ static int status2errno(int status)
> */
> static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t gfp)
> {
> if (skb && !skb_is_nonlinear(skb) && !skb_cloned(skb)) {
> skb_trim(skb, 0);
> skb_get(skb);
> skb_reset_transport_header(skb);
> } else {
> + if (!skb)
> + kfree(skb);
> skb = alloc_skb(len, gfp);
> }
> t4_set_arp_err_handler(skb, NULL, NULL);
Should be 'if (skb)'
:)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-16 15:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-16 15:03 [PATCHv2] Checks for Null value in function *get_skub Nicholas Krause
2014-06-16 15:04 ` Steve Wise
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox