* [PATCH 14/14] video: of: display_timing: delete unneeded test before of_node_put
@ 2014-08-08 10:07 Julia Lawall
2014-08-26 10:36 ` Tomi Valkeinen
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2014-08-08 10:07 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard
Cc: kernel-janitors, Tomi Valkeinen, linux-fbdev, linux-kernel,
Uwe Kleine-König
From: Julia Lawall <Julia.Lawall@lip6.fr>
Of_node_put supports NULL as its argument, so the initial test is not
necessary. Furthermore, native_mode cannot be NULL at this point.
Suggested by Uwe Kleine-König.
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e;
@@
-if (e)
of_node_put(e);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/video/of_display_timing.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c
index 987edf1..339f831 100644
--- a/drivers/video/of_display_timing.c
+++ b/drivers/video/of_display_timing.c
@@ -233,8 +233,7 @@ struct display_timings *of_get_display_timings(struct device_node *np)
return disp;
timingfail:
- if (native_mode)
- of_node_put(native_mode);
+ of_node_put(native_mode);
display_timings_release(disp);
entryfail:
kfree(disp);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 14/14] video: of: display_timing: delete unneeded test before of_node_put
2014-08-08 10:07 [PATCH 14/14] video: of: display_timing: delete unneeded test before of_node_put Julia Lawall
@ 2014-08-26 10:36 ` Tomi Valkeinen
0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2014-08-26 10:36 UTC (permalink / raw)
To: Julia Lawall, Jean-Christophe Plagniol-Villard
Cc: kernel-janitors, linux-fbdev, linux-kernel, Uwe Kleine-König
[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]
On 08/08/14 13:07, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Of_node_put supports NULL as its argument, so the initial test is not
> necessary. Furthermore, native_mode cannot be NULL at this point.
>
> Suggested by Uwe Kleine-König.
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression e;
> @@
>
> -if (e)
> of_node_put(e);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/video/of_display_timing.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c
> index 987edf1..339f831 100644
> --- a/drivers/video/of_display_timing.c
> +++ b/drivers/video/of_display_timing.c
> @@ -233,8 +233,7 @@ struct display_timings *of_get_display_timings(struct device_node *np)
> return disp;
>
> timingfail:
> - if (native_mode)
> - of_node_put(native_mode);
> + of_node_put(native_mode);
> display_timings_release(disp);
> entryfail:
> kfree(disp);
>
Thanks, queued for 3.18.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-26 10:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-08 10:07 [PATCH 14/14] video: of: display_timing: delete unneeded test before of_node_put Julia Lawall
2014-08-26 10:36 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox