* [PATCH] x86: Restore missing cpumask_copy() in __x2apic_send_IPI_mask
@ 2014-09-05 19:34 Ted Percival
2014-09-05 20:12 ` Ted Percival
0 siblings, 1 reply; 3+ messages in thread
From: Ted Percival @ 2014-09-05 19:34 UTC (permalink / raw)
To: Christoph Lameter, Tejun Heo; +Cc: linux-kernel, Ted Percival
This fixes a hang when initializing SMP CPUs at this point in the boot:
x86: Booting SMP configuration
.... node #0, CPUs: #1_
Fixes: 4ba2968420fa ("percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_t")
Signed-off-by: Ted Percival <ted@tedp.id.au>
---
arch/x86/kernel/apic/x2apic_cluster.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/kernel/apic/x2apic_cluster.c b/arch/x86/kernel/apic/x2apic_cluster.c
index 1f5d5f2ffae6..e658f21681c8 100644
--- a/arch/x86/kernel/apic/x2apic_cluster.c
+++ b/arch/x86/kernel/apic/x2apic_cluster.c
@@ -43,6 +43,7 @@ __x2apic_send_IPI_mask(const struct cpumask *mask, int vector, int apic_dest)
* and be sure it's manipulated with irq off.
*/
ipi_mask_ptr = this_cpu_cpumask_var_ptr(ipi_mask);
+ cpumask_copy(ipi_mask_ptr, mask);
/*
* The idea is to send one IPI per cluster.
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: Restore missing cpumask_copy() in __x2apic_send_IPI_mask
2014-09-05 19:34 [PATCH] x86: Restore missing cpumask_copy() in __x2apic_send_IPI_mask Ted Percival
@ 2014-09-05 20:12 ` Ted Percival
2014-09-05 20:18 ` Ted Percival
0 siblings, 1 reply; 3+ messages in thread
From: Ted Percival @ 2014-09-05 20:12 UTC (permalink / raw)
To: Christoph Lameter, Tejun Heo; +Cc: linux-kernel
On 09/05/2014 01:34 PM, Ted Percival wrote:
> This fixes a hang when initializing SMP CPUs at this point in the boot:
Looks like git-send-email picked up the wrong From address. I'll
resubmit with a consistent email address.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] x86: Restore missing cpumask_copy() in __x2apic_send_IPI_mask
2014-09-05 20:12 ` Ted Percival
@ 2014-09-05 20:18 ` Ted Percival
0 siblings, 0 replies; 3+ messages in thread
From: Ted Percival @ 2014-09-05 20:18 UTC (permalink / raw)
To: Christoph Lameter, Tejun Heo; +Cc: linux-kernel, Ted Percival
This fixes a hang when initializing SMP CPUs at this point in the boot:
x86: Booting SMP configuration
.... node #0, CPUs: #1_
Fixes: 4ba2968420fa ("percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_t")
Signed-off-by: Ted Percival <ted@tedp.id.au>
---
arch/x86/kernel/apic/x2apic_cluster.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/kernel/apic/x2apic_cluster.c b/arch/x86/kernel/apic/x2apic_cluster.c
index 1f5d5f2ffae6..e658f21681c8 100644
--- a/arch/x86/kernel/apic/x2apic_cluster.c
+++ b/arch/x86/kernel/apic/x2apic_cluster.c
@@ -43,6 +43,7 @@ __x2apic_send_IPI_mask(const struct cpumask *mask, int vector, int apic_dest)
* and be sure it's manipulated with irq off.
*/
ipi_mask_ptr = this_cpu_cpumask_var_ptr(ipi_mask);
+ cpumask_copy(ipi_mask_ptr, mask);
/*
* The idea is to send one IPI per cluster.
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-05 20:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-05 19:34 [PATCH] x86: Restore missing cpumask_copy() in __x2apic_send_IPI_mask Ted Percival
2014-09-05 20:12 ` Ted Percival
2014-09-05 20:18 ` Ted Percival
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox