* [PATCH 2/2] xtensa/uapi: Add definition of TIOC[SG]RS485
@ 2014-09-09 5:20 Ricardo Ribalda Delgado
2014-09-09 15:24 ` Max Filippov
2014-09-09 19:18 ` Greg Kroah-Hartman
0 siblings, 2 replies; 6+ messages in thread
From: Ricardo Ribalda Delgado @ 2014-09-09 5:20 UTC (permalink / raw)
To: Greg Kroah-Hartman, Chris Zankel,
Max Filippov linux-xtensa @ linux-xtensa . org, linux-kernel,
linux-serial
Cc: Ricardo Ribalda Delgado
Commit: e676253b19b2d269cccf67fdb1592120a0cd0676 [3/21] serial/8250: Add
support for RS485 IOCTLs, adds support for RS485 ioctls for 825_core on
all the archs. Unfortunaltely the definition of TIOCSRS485 and
TIOCGRS485 was missing on the ioctls.h file
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
arch/xtensa/include/uapi/asm/ioctls.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/xtensa/include/uapi/asm/ioctls.h b/arch/xtensa/include/uapi/asm/ioctls.h
index a47909f..accda82 100644
--- a/arch/xtensa/include/uapi/asm/ioctls.h
+++ b/arch/xtensa/include/uapi/asm/ioctls.h
@@ -95,6 +95,8 @@
#define TCSETS2 _IOW('T', 43, struct termios2)
#define TCSETSW2 _IOW('T', 44, struct termios2)
#define TCSETSF2 _IOW('T', 45, struct termios2)
+#define TIOCGRS485 0x542E
+#define TIOCSRS485 0x542F
#define TIOCGPTN _IOR('T',0x30, unsigned int) /* Get Pty Number (of pty-mux device) */
#define TIOCSPTLCK _IOW('T',0x31, int) /* Lock/unlock Pty */
#define TIOCGDEV _IOR('T',0x32, unsigned int) /* Get primary device node of /dev/console */
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] xtensa/uapi: Add definition of TIOC[SG]RS485
2014-09-09 5:20 [PATCH 2/2] xtensa/uapi: Add definition of TIOC[SG]RS485 Ricardo Ribalda Delgado
@ 2014-09-09 15:24 ` Max Filippov
2014-09-09 17:32 ` Ricardo Ribalda Delgado
2014-09-09 19:18 ` Greg Kroah-Hartman
1 sibling, 1 reply; 6+ messages in thread
From: Max Filippov @ 2014-09-09 15:24 UTC (permalink / raw)
To: Ricardo Ribalda Delgado
Cc: Greg Kroah-Hartman, Chris Zankel, LKML, linux-serial
On Mon, Sep 8, 2014 at 10:20 PM, Ricardo Ribalda Delgado
<ricardo.ribalda@gmail.com> wrote:
> Commit: e676253b19b2d269cccf67fdb1592120a0cd0676 [3/21] serial/8250: Add
> support for RS485 IOCTLs, adds support for RS485 ioctls for 825_core on
> all the archs. Unfortunaltely the definition of TIOCSRS485 and
> TIOCGRS485 was missing on the ioctls.h file
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
> arch/xtensa/include/uapi/asm/ioctls.h | 2 ++
> 1 file changed, 2 insertions(+)
Acked-by: Max Filippov <jcmvbkbc@gmail.com>
If you want this patch to go through the xtensa tree please let me know,
I'll include it to my fixes branch then.
--
Thanks.
-- Max
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] xtensa/uapi: Add definition of TIOC[SG]RS485
2014-09-09 15:24 ` Max Filippov
@ 2014-09-09 17:32 ` Ricardo Ribalda Delgado
2014-09-09 17:40 ` Chris Zankel
0 siblings, 1 reply; 6+ messages in thread
From: Ricardo Ribalda Delgado @ 2014-09-09 17:32 UTC (permalink / raw)
To: Max Filippov; +Cc: Greg Kroah-Hartman, Chris Zankel, LKML, linux-serial
Hello Max
I really don't know who should do it, the maintainer of tty-next or
you :). I guess Greg will want that his is fixed on his tree asap,
since that build is broken.
Lets give him some time to reply, if nothing happens, then please
apply it through your tree.
Best regards
On Tue, Sep 9, 2014 at 5:24 PM, Max Filippov <jcmvbkbc@gmail.com> wrote:
> On Mon, Sep 8, 2014 at 10:20 PM, Ricardo Ribalda Delgado
> <ricardo.ribalda@gmail.com> wrote:
>> Commit: e676253b19b2d269cccf67fdb1592120a0cd0676 [3/21] serial/8250: Add
>> support for RS485 IOCTLs, adds support for RS485 ioctls for 825_core on
>> all the archs. Unfortunaltely the definition of TIOCSRS485 and
>> TIOCGRS485 was missing on the ioctls.h file
>>
>> Reported-by: kbuild test robot <fengguang.wu@intel.com>
>> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
>> ---
>> arch/xtensa/include/uapi/asm/ioctls.h | 2 ++
>> 1 file changed, 2 insertions(+)
>
> Acked-by: Max Filippov <jcmvbkbc@gmail.com>
>
> If you want this patch to go through the xtensa tree please let me know,
> I'll include it to my fixes branch then.
>
> --
> Thanks.
> -- Max
--
Ricardo Ribalda
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] xtensa/uapi: Add definition of TIOC[SG]RS485
2014-09-09 17:32 ` Ricardo Ribalda Delgado
@ 2014-09-09 17:40 ` Chris Zankel
0 siblings, 0 replies; 6+ messages in thread
From: Chris Zankel @ 2014-09-09 17:40 UTC (permalink / raw)
To: Ricardo Ribalda Delgado, Max Filippov
Cc: Greg Kroah-Hartman, LKML, linux-serial
Hi Ricardo,
I'll add it to the xtensa-next tree today..
Thanks,
-Chris
On 9/9/14, 10:32 AM, Ricardo Ribalda Delgado wrote:
> Hello Max
>
> I really don't know who should do it, the maintainer of tty-next or
> you :). I guess Greg will want that his is fixed on his tree asap,
> since that build is broken.
>
> Lets give him some time to reply, if nothing happens, then please
> apply it through your tree.
>
>
> Best regards
>
> On Tue, Sep 9, 2014 at 5:24 PM, Max Filippov <jcmvbkbc@gmail.com> wrote:
>> On Mon, Sep 8, 2014 at 10:20 PM, Ricardo Ribalda Delgado
>> <ricardo.ribalda@gmail.com> wrote:
>>> Commit: e676253b19b2d269cccf67fdb1592120a0cd0676 [3/21] serial/8250: Add
>>> support for RS485 IOCTLs, adds support for RS485 ioctls for 825_core on
>>> all the archs. Unfortunaltely the definition of TIOCSRS485 and
>>> TIOCGRS485 was missing on the ioctls.h file
>>>
>>> Reported-by: kbuild test robot <fengguang.wu@intel.com>
>>> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
>>> ---
>>> arch/xtensa/include/uapi/asm/ioctls.h | 2 ++
>>> 1 file changed, 2 insertions(+)
>> Acked-by: Max Filippov <jcmvbkbc@gmail.com>
>>
>> If you want this patch to go through the xtensa tree please let me know,
>> I'll include it to my fixes branch then.
>>
>> --
>> Thanks.
>> -- Max
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] xtensa/uapi: Add definition of TIOC[SG]RS485
2014-09-09 5:20 [PATCH 2/2] xtensa/uapi: Add definition of TIOC[SG]RS485 Ricardo Ribalda Delgado
2014-09-09 15:24 ` Max Filippov
@ 2014-09-09 19:18 ` Greg Kroah-Hartman
2014-09-09 19:40 ` Ricardo Ribalda Delgado
1 sibling, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2014-09-09 19:18 UTC (permalink / raw)
To: Ricardo Ribalda Delgado
Cc: Chris Zankel, Max Filippov linux-xtensa @ linux-xtensa . org,
linux-kernel, linux-serial
On Tue, Sep 09, 2014 at 07:20:56AM +0200, Ricardo Ribalda Delgado wrote:
> Commit: e676253b19b2d269cccf67fdb1592120a0cd0676 [3/21] serial/8250: Add
> support for RS485 IOCTLs, adds support for RS485 ioctls for 825_core on
> all the archs. Unfortunaltely the definition of TIOCSRS485 and
> TIOCGRS485 was missing on the ioctls.h file
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
> arch/xtensa/include/uapi/asm/ioctls.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/xtensa/include/uapi/asm/ioctls.h b/arch/xtensa/include/uapi/asm/ioctls.h
> index a47909f..accda82 100644
> --- a/arch/xtensa/include/uapi/asm/ioctls.h
> +++ b/arch/xtensa/include/uapi/asm/ioctls.h
> @@ -95,6 +95,8 @@
> #define TCSETS2 _IOW('T', 43, struct termios2)
> #define TCSETSW2 _IOW('T', 44, struct termios2)
> #define TCSETSF2 _IOW('T', 45, struct termios2)
> +#define TIOCGRS485 0x542E
> +#define TIOCSRS485 0x542F
Like your patches for other arches, please use a _IOW() macro here, not a "number".
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] xtensa/uapi: Add definition of TIOC[SG]RS485
2014-09-09 19:18 ` Greg Kroah-Hartman
@ 2014-09-09 19:40 ` Ricardo Ribalda Delgado
0 siblings, 0 replies; 6+ messages in thread
From: Ricardo Ribalda Delgado @ 2014-09-09 19:40 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Chris Zankel, Max Filippov linux-xtensa @ linux-xtensa . org,
LKML, linux-serial
Done
Thanks :)
On Tue, Sep 9, 2014 at 9:18 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Tue, Sep 09, 2014 at 07:20:56AM +0200, Ricardo Ribalda Delgado wrote:
>> Commit: e676253b19b2d269cccf67fdb1592120a0cd0676 [3/21] serial/8250: Add
>> support for RS485 IOCTLs, adds support for RS485 ioctls for 825_core on
>> all the archs. Unfortunaltely the definition of TIOCSRS485 and
>> TIOCGRS485 was missing on the ioctls.h file
>>
>> Reported-by: kbuild test robot <fengguang.wu@intel.com>
>> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
>> ---
>> arch/xtensa/include/uapi/asm/ioctls.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/xtensa/include/uapi/asm/ioctls.h b/arch/xtensa/include/uapi/asm/ioctls.h
>> index a47909f..accda82 100644
>> --- a/arch/xtensa/include/uapi/asm/ioctls.h
>> +++ b/arch/xtensa/include/uapi/asm/ioctls.h
>> @@ -95,6 +95,8 @@
>> #define TCSETS2 _IOW('T', 43, struct termios2)
>> #define TCSETSW2 _IOW('T', 44, struct termios2)
>> #define TCSETSF2 _IOW('T', 45, struct termios2)
>> +#define TIOCGRS485 0x542E
>> +#define TIOCSRS485 0x542F
>
> Like your patches for other arches, please use a _IOW() macro here, not a "number".
>
> thanks,
>
> greg k-h
--
Ricardo Ribalda
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-09-09 19:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-09 5:20 [PATCH 2/2] xtensa/uapi: Add definition of TIOC[SG]RS485 Ricardo Ribalda Delgado
2014-09-09 15:24 ` Max Filippov
2014-09-09 17:32 ` Ricardo Ribalda Delgado
2014-09-09 17:40 ` Chris Zankel
2014-09-09 19:18 ` Greg Kroah-Hartman
2014-09-09 19:40 ` Ricardo Ribalda Delgado
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox