[PATCH v3] clk: Show the clock rate when fail to set clock rate

[PATCH v3] clk: Show the clock rate when fail to set clock rate

[Chanwoo Choi]

This patch shows the current clock rate when fail to set the clock rate.
because original error message show the error value instead of currrent clock
rate.

Cc: Mike Turquette <mturquette@linaro.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
Changes from v2:
- Show the current clock rate when fail to set clock rate
Changes from v1:
- Add error value of clk_set_rate() with current clock rate

 drivers/clk/clk-conf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/clk-conf.c b/drivers/clk/clk-conf.c
index 48a65b2..53d7449 100644
--- a/drivers/clk/clk-conf.c
+++ b/drivers/clk/clk-conf.c
@@ -106,8 +106,8 @@ static int __set_clk_rates(struct device_node *node, bool clk_supplier)
 
 			rc = clk_set_rate(clk, rate);
 			if (rc < 0)
-				pr_err("clk: couldn't set %s clock rate: %d\n",
-				       __clk_get_name(clk), rc);
+				pr_err("clk: couldn't set %s clk rate to %ld\n",
+				       __clk_get_name(clk), rate);
 			clk_put(clk);
 		}
 		index++;
-- 
1.8.5.5

Re: [PATCH v3] clk: Show the clock rate when fail to set clock rate

[Chanwoo Choi]

Dear all,

Please ignore this patch. I'll send v4 patch.

Thanks,
Chanwoo Choi

On 04/27/2015 05:53 PM, Chanwoo Choi wrote:
> This patch shows the current clock rate when fail to set the clock rate.
> because original error message show the error value instead of currrent clock
> rate.
> 
> Cc: Mike Turquette <mturquette@linaro.org>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> Changes from v2:
> - Show the current clock rate when fail to set clock rate
> Changes from v1:
> - Add error value of clk_set_rate() with current clock rate
> 
>  drivers/clk/clk-conf.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/clk-conf.c b/drivers/clk/clk-conf.c
> index 48a65b2..53d7449 100644
> --- a/drivers/clk/clk-conf.c
> +++ b/drivers/clk/clk-conf.c
> @@ -106,8 +106,8 @@ static int __set_clk_rates(struct device_node *node, bool clk_supplier)
>  
>  			rc = clk_set_rate(clk, rate);
>  			if (rc < 0)
> -				pr_err("clk: couldn't set %s clock rate: %d\n",
> -				       __clk_get_name(clk), rc);
> +				pr_err("clk: couldn't set %s clk rate to %ld\n",
> +				       __clk_get_name(clk), rate);
>  			clk_put(clk);
>  		}
>  		index++;
>