From: "H. Peter Anvin" <hpa@zytor.com>
To: Borislav Petkov <bp@alien8.de>,
Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Cc: tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: include: asm: Fix build warning
Date: Tue, 29 Sep 2015 10:08:58 -0700 [thread overview]
Message-ID: <560AC5AA.7080203@zytor.com> (raw)
In-Reply-To: <20150929170651.GA3551@pd.tnic>
On 09/29/2015 10:06 AM, Borislav Petkov wrote:
> On Tue, Sep 29, 2015 at 06:25:46PM +0200, Ksenija Stanojevic wrote:
>> Fix build warnings:
>>
>> error: implicit declaration of function ‘olpc_board_at_least’
>> [-Werror=implicit-function-declaration]
>>
>> error: implicit declaration of function ‘olpc_board’
>> [-Werror=implicit-function-declaration]
>
> How exactly do you trigger that?
>
>> in files:
>> drivers/power/olpc_battery.c
>> drivers/input/mouse/hgpk.c
>> drivers/staging/olpc_dcon/olpc_dcon.c
>> arch/x86/platform/olpc/olpc.c
>> sound/pci/cs5535audio/cs5535audio_olpc.c
>
> AFAICT, those should all depend on CONFIG_OLPC which defines those
> functions...
>
It wouldn't be entirely impossible if OLPC has bitrotted. This is one
of the many problems with nonstandard hardware.
-hpa
next prev parent reply other threads:[~2015-09-29 17:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 16:25 [PATCH] x86: include: asm: Fix build warning Ksenija Stanojevic
2015-09-29 17:06 ` Borislav Petkov
2015-09-29 17:08 ` H. Peter Anvin [this message]
2015-09-29 17:12 ` Ksenija Stanojević
2015-09-29 17:16 ` Borislav Petkov
2015-09-29 17:19 ` Ksenija Stanojević
2015-09-29 17:31 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560AC5AA.7080203@zytor.com \
--to=hpa@zytor.com \
--cc=bp@alien8.de \
--cc=ksenija.stanojevic@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox