public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Laura Abbott <laura@labbott.name>
To: Dzonatans Melgalvis <dz.melgalvis@gmail.com>, gregkh@linuxfoundation.org
Cc: arve@android.com, riandrews@android.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: android: uapi: fixed comment block coding style error in ion.h
Date: Mon, 26 Oct 2015 14:41:23 -0700	[thread overview]
Message-ID: <562E9E03.1080509@labbott.name> (raw)
In-Reply-To: <1445811414-10953-1-git-send-email-dz.melgalvis@gmail.com>

On 10/25/15 3:16 PM, Dzonatans Melgalvis wrote:
> Fixed checkpatch.pl warning about comment block coding style.
>

The right aligned comments aren't great style.
How about moving the comments (with the correct style) right
above the macro they are describing.

> Signed-off-by: Dzonatans Melgalvis <dz.melgalvis@gmail.com>
> ---
>   drivers/staging/android/uapi/ion.h | 14 ++++++++------
>   1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
> index 68a14b4..11df59f 100644
> --- a/drivers/staging/android/uapi/ion.h
> +++ b/drivers/staging/android/uapi/ion.h
> @@ -56,13 +56,15 @@ enum ion_heap_type {
>    * allocation flags - the lower 16 bits are used by core ion, the upper 16
>    * bits are reserved for use by the heaps themselves.
>    */
> -#define ION_FLAG_CACHED 1		/* mappings of this buffer should be
> -					   cached, ion will do cache
> -					   maintenance when the buffer is
> -					   mapped for dma */
> +#define ION_FLAG_CACHED 1		/*  mappings of this buffer should be
> +					 *  cached, ion will do cache
> +					 *  maintenance when the buffer is
> +					 *  mapped for dma
> +					 */
>   #define ION_FLAG_CACHED_NEEDS_SYNC 2	/* mappings of this buffer will created
> -					   at mmap time, if this is set
> -					   caches must be managed manually */
> +					 *  at mmap time, if this is set
> +					 *  caches must be managed manually
> +					 */
>
>   /**
>    * DOC: Ion Userspace API
>


      reply	other threads:[~2015-10-26 21:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-25 22:16 [PATCH] Staging: android: uapi: fixed comment block coding style error in ion.h Dzonatans Melgalvis
2015-10-26 21:41 ` Laura Abbott [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562E9E03.1080509@labbott.name \
    --to=laura@labbott.name \
    --cc=arve@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dz.melgalvis@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riandrews@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox