[PATCH] MIPS: fix build failure

[PATCH] MIPS: fix build failure

[Sudip Mukherjee]

While building for mips defconfig the build failed with the error:
In function 'create_elf_tables':
arch/mips/include/asm/elf.h:425:14: error: 
'AT_SYSINFO_EHDR' undeclared (first use in this function)

AT_SYSINFO_EHDR is defined in uapi/asm/auxvec.h which was not included
here.

Fixes: c1fb442ade67 ("MIPS: Initial implementation of a VDSO")
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---

This patch is based on mips-for-linux-next branch.

 arch/mips/include/asm/elf.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/include/asm/elf.h b/arch/mips/include/asm/elf.h
index b01a6ff..acd6da2 100644
--- a/arch/mips/include/asm/elf.h
+++ b/arch/mips/include/asm/elf.h
@@ -11,6 +11,7 @@
 #include <linux/auxvec.h>
 #include <linux/fs.h>
 #include <uapi/linux/elf.h>
+#include <uapi/asm/auxvec.h>
 
 #include <asm/cpu-info.h>
 #include <asm/current.h>
-- 
1.9.1

Re: [PATCH] MIPS: fix build failure

[Markos Chandras]

On 10/28/2015 10:08 AM, Sudip Mukherjee wrote:
> While building for mips defconfig the build failed with the error:
> In function 'create_elf_tables':
> arch/mips/include/asm/elf.h:425:14: error: 
> 'AT_SYSINFO_EHDR' undeclared (first use in this function)
> 
> AT_SYSINFO_EHDR is defined in uapi/asm/auxvec.h which was not included
> here.
> 
> Fixes: c1fb442ade67 ("MIPS: Initial implementation of a VDSO")
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> 
> This patch is based on mips-for-linux-next branch.
> 

Something is not right here. The <linux/auxvec.h> header is already
included in that file which in turns includes uapi/asm/auxvec.h

I haven't seen this failure in Ralf's tree. Could you share your .config
and perhaps the hash of the mips-for-linux-next tree you tried it on?


-- 
markos

Re: [PATCH] MIPS: fix build failure

[Markos Chandras]

On 10/28/2015 10:18 AM, Markos Chandras wrote:
> On 10/28/2015 10:08 AM, Sudip Mukherjee wrote:
>> While building for mips defconfig the build failed with the error:
>> In function 'create_elf_tables':
>> arch/mips/include/asm/elf.h:425:14: error: 
>> 'AT_SYSINFO_EHDR' undeclared (first use in this function)
>>
>> AT_SYSINFO_EHDR is defined in uapi/asm/auxvec.h which was not included
>> here.
>>
>> Fixes: c1fb442ade67 ("MIPS: Initial implementation of a VDSO")
>> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
>> ---
>>
>> This patch is based on mips-for-linux-next branch.
>>
> 
> Something is not right here. The <linux/auxvec.h> header is already
> included in that file which in turns includes uapi/asm/auxvec.h
> 
> I haven't seen this failure in Ralf's tree. Could you share your .config
> and perhaps the hash of the mips-for-linux-next tree you tried it on?
> 
> 
I believe your problem might be similar to this

https://www.linux-mips.org/archives/linux-mips/2015-10/msg00280.html

in other words either remove the generated headers or do a 'make
mrproper' (make sure to backup your .config) and try again

-- 
markos

Re: [PATCH] MIPS: fix build failure

[Sudip Mukherjee]

On Wed, Oct 28, 2015 at 10:31:24AM +0000, Markos Chandras wrote:
> On 10/28/2015 10:18 AM, Markos Chandras wrote:
> > On 10/28/2015 10:08 AM, Sudip Mukherjee wrote:
> >> While building for mips defconfig the build failed with the error:
> >> In function 'create_elf_tables':
> >> arch/mips/include/asm/elf.h:425:14: error: 
> >> 'AT_SYSINFO_EHDR' undeclared (first use in this function)
> >>
> >> AT_SYSINFO_EHDR is defined in uapi/asm/auxvec.h which was not included
> >> here.
> >>
> >> Fixes: c1fb442ade67 ("MIPS: Initial implementation of a VDSO")
> >> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> >> ---
> >>
> >> This patch is based on mips-for-linux-next branch.
> >>
> > 
> > Something is not right here. The <linux/auxvec.h> header is already
> > included in that file which in turns includes uapi/asm/auxvec.h
> > 
> > I haven't seen this failure in Ralf's tree. Could you share your .config
> > and perhaps the hash of the mips-for-linux-next tree you tried it on?
> > 
> > 
> I believe your problem might be similar to this
> 
> https://www.linux-mips.org/archives/linux-mips/2015-10/msg00280.html
> 
> in other words either remove the generated headers or do a 'make
> mrproper' (make sure to backup your .config) and try again

Yes, I did a make distclean to be sure everything is clean. And it
builds properly. Please discard the patch.
Sorry for the noise.

regards
sudip