From: Andy Yan <andy.yan@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: naobsd@gmail.com, robh+dt@kernel.org, linux@arm.linux.org.uk,
devicetree@vger.kernel.org, galak@codeaurora.org,
linux-kernel@vger.kernel.org, ijc+devicetree@hellion.org.uk,
linux-rockchip@lists.infradead.org, pawel.moll@arm.com,
mark.rutland@arm.com, inux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: rockchip: enable pwm3 as pwm regulator for rk3066a-rayeager board
Date: Fri, 15 Jan 2016 18:41:52 +0800 [thread overview]
Message-ID: <5698CCF0.8040406@rock-chips.com> (raw)
In-Reply-To: <2237362.fjXobafQhV@phil>
Hi Heiko:
On 2016年01月14日 20:41, Heiko Stuebner wrote:
> Hi Andy,
>
> Am Donnerstag, 14. Januar 2016, 20:35:56 schrieb Andy Yan:
>> Rayeager board use pwm3 modulate the vdd_logic voltage, so enable it.
>>
>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>> ---
>>
>> arch/arm/boot/dts/rk3066a-rayeager.dts | 16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3066a-rayeager.dts
>> b/arch/arm/boot/dts/rk3066a-rayeager.dts index 3d4c104..d17a5b8 100644
>> --- a/arch/arm/boot/dts/rk3066a-rayeager.dts
>> +++ b/arch/arm/boot/dts/rk3066a-rayeager.dts
>> @@ -78,6 +78,18 @@
>> };
>> };
>>
>> + pwm_regulator: pwm-regulator {
>> + compatible = "pwm-regulator";
>> + pwms = <&pwm3 0 1000>;
>> + regulator-name = "vdd_logic";
>> + regulator-min-microvolt = <1200000>;
>> + regulator-max-microvolt = <1200000>;
> I guess this is to make sure it stays at 1.2V at all times, or is the min-
> microvolt settings supposed to be lower?
>
>
> Thanks
> Heiko
>
>
>
Yes, I want to fix it at 1.2V. When I read the regulator_register
function, I found it call regulator_do_set_voltate only when min=max.
So I set it like what you see.
regulator_register--->
set_machine_constrains--->
machine_constrains_voltage-->
prev parent reply other threads:[~2016-01-15 10:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 12:33 [PATCH 0/2] fix rk3066a-rayeager board hang when cpufreq changes Andy Yan
2016-01-14 12:34 ` [PATCH 1/2] ARM: dts: rockchip: increase vdd_arm voltage for rk3066a-rayeager board Andy Yan
2016-01-14 12:45 ` Heiko Stuebner
2016-01-14 12:35 ` [PATCH 2/2] ARM: dts: rockchip: enable pwm3 as pwm regulator " Andy Yan
2016-01-14 12:41 ` Heiko Stuebner
2016-01-15 10:41 ` Andy Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5698CCF0.8040406@rock-chips.com \
--to=andy.yan@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=inux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=naobsd@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox