From: Michal Marek <mmarek@suse.cz>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
linux@roeck-us.net, arnd@arndb.de, rusty@rustcorp.com.au
Subject: Re: [PATCH] scripts/link-vmlinux.sh: force error on kallsyms failure
Date: Fri, 5 Feb 2016 10:58:33 +0100 [thread overview]
Message-ID: <56B47249.1060603@suse.cz> (raw)
In-Reply-To: <1454605779-30869-1-git-send-email-ard.biesheuvel@linaro.org>
On 2016-02-04 18:09, Ard Biesheuvel wrote:
> - ${NM} -n ${1} | \
> - scripts/kallsyms ${kallsymopt} | \
> - ${CC} ${aflags} -c -o ${2} -x assembler-with-cpp -
> + # capture the return code of scripts/kallsyms in $RC
> + local RC=`(${NM} -n ${1} | \
> + (scripts/kallsyms ${kallsymopt}; echo $? 1>&3) | \
> + ${CC} ${aflags} -c -o ${2} -x assembler-with-cpp -) 3>&1`
> +
> + [ $RC -eq 0 ]
This now ignores errors by the assembler (and makes the function hard to
read). Please change it to use a temporary file.
Michal
prev parent reply other threads:[~2016-02-05 9:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 17:09 [PATCH] scripts/link-vmlinux.sh: force error on kallsyms failure Ard Biesheuvel
2016-02-05 9:58 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B47249.1060603@suse.cz \
--to=mmarek@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox