From: Marc Zyngier <marc.zyngier@arm.com>
To: Antoine Tenart <antoine.tenart@free-electrons.com>,
Thomas Gleixner <tglx@linutronix.de>
Cc: jason@lakedaemon.net, tsahee@annapurnalabs.com,
rshitrit@annapurnalabs.com, thomas.petazzoni@free-electrons.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller
Date: Mon, 8 Feb 2016 14:29:12 +0000 [thread overview]
Message-ID: <56B8A638.1040903@arm.com> (raw)
In-Reply-To: <20160208141754.GG4117@kwain>
On 08/02/16 14:17, Antoine Tenart wrote:
> Thomas,
>
> On Mon, Feb 08, 2016 at 11:31:47AM +0100, Thomas Gleixner wrote:
>> On Mon, 8 Feb 2016, Antoine Tenart wrote:
>>> +static int alpine_msix_set_affinity(struct irq_data *irq_data,
>>> + const struct cpumask *mask, bool force)
>>> +{
>>> + int ret;
>>> +
>>> + ret = irq_chip_set_affinity_parent(irq_data, mask, force);
>>> + return ret == IRQ_SET_MASK_OK ? IRQ_SET_MASK_OK_DONE : ret;
>>
>> What's the point of this exercise? Why can't you just set the affinity
>> callback to irq_chip_set_affinity_parent() ?
>
> That's what done in irq-gic-v2m.c. Besides that, I see no point. I'll
> update for v2.
That's because there is no need to do another compose_msi_msg/write_msg
in msi_domain_set_affinity() once the affinity has been updated at the
GIC level. Alternatively, updating the GIC driver to always return
IRQ_SET_MASK_OK_DONE would be perfectly acceptable.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2016-02-08 14:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 9:16 [PATCH 0/6] irqchip: introduce the Alpine MSIX driver Antoine Tenart
2016-02-08 9:16 ` [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller Antoine Tenart
2016-02-08 9:44 ` Marc Zyngier
2016-02-08 9:53 ` Thomas Petazzoni
2016-02-08 10:08 ` Marc Zyngier
2016-02-08 10:26 ` Antoine Tenart
2016-02-08 10:32 ` Marc Zyngier
2016-02-08 10:44 ` Antoine Tenart
2016-02-08 10:56 ` Marc Zyngier
2016-02-08 11:01 ` Antoine Tenart
2016-02-08 14:04 ` Antoine Tenart
2016-02-08 14:11 ` Marc Zyngier
2016-02-08 10:31 ` Thomas Gleixner
2016-02-08 14:17 ` Antoine Tenart
2016-02-08 14:29 ` Marc Zyngier [this message]
2016-02-08 14:48 ` Antoine Tenart
2016-02-08 15:01 ` Marc Zyngier
2016-02-08 9:16 ` [PATCH 2/6] Documentation: bindings: document the Alpine MSIX driver Antoine Tenart
2016-02-08 14:55 ` Marc Zyngier
2016-02-08 15:05 ` Antoine Tenart
2016-02-08 9:16 ` [PATCH 3/6] arm64: dts: alpine: add the MSIX node in the Alpine v2 dtsi Antoine Tenart
2016-02-08 9:16 ` [PATCH 4/6] ARM: dts: alpine: add the MSIX node Antoine Tenart
2016-02-08 9:16 ` [PATCH 5/6] arm64: alpine: select the Alpine MSI controller driver Antoine Tenart
2016-02-08 9:16 ` [PATCH 6/6] arm: " Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B8A638.1040903@arm.com \
--to=marc.zyngier@arm.com \
--cc=antoine.tenart@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rshitrit@annapurnalabs.com \
--cc=tglx@linutronix.de \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tsahee@annapurnalabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox