From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>,
tglx@linutronix.de, jason@lakedaemon.net,
tsahee@annapurnalabs.com, rshitrit@annapurnalabs.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller
Date: Mon, 8 Feb 2016 10:53:22 +0100 [thread overview]
Message-ID: <20160208105322.78b20cba@free-electrons.com> (raw)
In-Reply-To: <56B86391.1030609@arm.com>
Hello Marc,
On Mon, 8 Feb 2016 09:44:49 +0000, Marc Zyngier wrote:
> > +static struct msi_domain_info alpine_msix_domain_info = {
> > + .flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
> > + MSI_FLAG_PCI_MSIX,
>
> You can probably add MSI_FLAG_PCI_MSI, it should work as well (MULTI_MSI
> obviously won't).
Why wouldn't MULTI_MSI work? The code is using
bitmap_find_next_zero_area() in alpine_msix_allocate_sgi() precisely to
find num_req consecutive bits set to 0, in order to allocate multiple
MSIs at once. Am I missing something?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-02-08 9:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 9:16 [PATCH 0/6] irqchip: introduce the Alpine MSIX driver Antoine Tenart
2016-02-08 9:16 ` [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller Antoine Tenart
2016-02-08 9:44 ` Marc Zyngier
2016-02-08 9:53 ` Thomas Petazzoni [this message]
2016-02-08 10:08 ` Marc Zyngier
2016-02-08 10:26 ` Antoine Tenart
2016-02-08 10:32 ` Marc Zyngier
2016-02-08 10:44 ` Antoine Tenart
2016-02-08 10:56 ` Marc Zyngier
2016-02-08 11:01 ` Antoine Tenart
2016-02-08 14:04 ` Antoine Tenart
2016-02-08 14:11 ` Marc Zyngier
2016-02-08 10:31 ` Thomas Gleixner
2016-02-08 14:17 ` Antoine Tenart
2016-02-08 14:29 ` Marc Zyngier
2016-02-08 14:48 ` Antoine Tenart
2016-02-08 15:01 ` Marc Zyngier
2016-02-08 9:16 ` [PATCH 2/6] Documentation: bindings: document the Alpine MSIX driver Antoine Tenart
2016-02-08 14:55 ` Marc Zyngier
2016-02-08 15:05 ` Antoine Tenart
2016-02-08 9:16 ` [PATCH 3/6] arm64: dts: alpine: add the MSIX node in the Alpine v2 dtsi Antoine Tenart
2016-02-08 9:16 ` [PATCH 4/6] ARM: dts: alpine: add the MSIX node Antoine Tenart
2016-02-08 9:16 ` [PATCH 5/6] arm64: alpine: select the Alpine MSI controller driver Antoine Tenart
2016-02-08 9:16 ` [PATCH 6/6] arm: " Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208105322.78b20cba@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=antoine.tenart@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=rshitrit@annapurnalabs.com \
--cc=tglx@linutronix.de \
--cc=tsahee@annapurnalabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox