From: Peter Hurley <peter@hurleysoftware.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tty: audit: remove unused variable
Date: Tue, 1 Mar 2016 08:10:18 -0800 [thread overview]
Message-ID: <56D5BEEA.7010206@hurleysoftware.com> (raw)
In-Reply-To: <1456312509-21904-1-git-send-email-sudipm.mukherjee@gmail.com>
On 02/24/2016 03:15 AM, Sudip Mukherjee wrote:
> While building with W=1 we were getting build warning:
> drivers/tty/tty_audit.c:149:16: warning: variable 'sessionid' set but not used
>
> The local variable sessionid was only assigned the value of
> current->sessionid but was never reused. On further inspection it turned
> out that there is no need of audit_get_loginuid() also.
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
prev parent reply other threads:[~2016-03-01 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 11:15 [PATCH v2] tty: audit: remove unused variable Sudip Mukherjee
2016-03-01 16:10 ` Peter Hurley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D5BEEA.7010206@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox