* [PATCH v2] tty: audit: remove unused variable
@ 2016-02-24 11:15 Sudip Mukherjee
2016-03-01 16:10 ` Peter Hurley
0 siblings, 1 reply; 2+ messages in thread
From: Sudip Mukherjee @ 2016-02-24 11:15 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby
Cc: linux-kernel, Sudip Mukherjee, Peter Hurley
While building with W=1 we were getting build warning:
drivers/tty/tty_audit.c:149:16: warning: variable 'sessionid' set but not used
The local variable sessionid was only assigned the value of
current->sessionid but was never reused. On further inspection it turned
out that there is no need of audit_get_loginuid() also.
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
v2: audit_get_loginuid() also removed.
drivers/tty/tty_audit.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/tty/tty_audit.c b/drivers/tty/tty_audit.c
index 66d53fc..df2d735 100644
--- a/drivers/tty/tty_audit.c
+++ b/drivers/tty/tty_audit.c
@@ -144,14 +144,8 @@ void tty_audit_tiocsti(struct tty_struct *tty, char ch)
if (tty_audit_push())
return;
- if (audit_enabled) {
- kuid_t auid;
- unsigned int sessionid;
-
- auid = audit_get_loginuid(current);
- sessionid = audit_get_sessionid(current);
+ if (audit_enabled)
tty_audit_log("ioctl=TIOCSTI", dev, &ch, 1);
- }
}
/**
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] tty: audit: remove unused variable
2016-02-24 11:15 [PATCH v2] tty: audit: remove unused variable Sudip Mukherjee
@ 2016-03-01 16:10 ` Peter Hurley
0 siblings, 0 replies; 2+ messages in thread
From: Peter Hurley @ 2016-03-01 16:10 UTC (permalink / raw)
To: Sudip Mukherjee, Greg Kroah-Hartman, Jiri Slaby; +Cc: linux-kernel
On 02/24/2016 03:15 AM, Sudip Mukherjee wrote:
> While building with W=1 we were getting build warning:
> drivers/tty/tty_audit.c:149:16: warning: variable 'sessionid' set but not used
>
> The local variable sessionid was only assigned the value of
> current->sessionid but was never reused. On further inspection it turned
> out that there is no need of audit_get_loginuid() also.
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-01 16:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-24 11:15 [PATCH v2] tty: audit: remove unused variable Sudip Mukherjee
2016-03-01 16:10 ` Peter Hurley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox