From: Ian Abbott <abbotti@mev.co.uk>
To: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>,
hsweeten@visionengravers.com, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] Staging: comedi:Fix checkpatch issue in s626.c
Date: Mon, 16 May 2016 11:02:38 +0100 [thread overview]
Message-ID: <57399ABE.5060707@mev.co.uk> (raw)
In-Reply-To: <1463036375-13527-2-git-send-email-ravishankarkm32@gmail.com>
On 12/05/16 07:59, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the s626.c file that fixes up a
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> found by the checkpatch.pl tool
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
> ---
> drivers/staging/comedi/drivers/s626.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
> index 43ab2e4..13f302d 100644
> --- a/drivers/staging/comedi/drivers/s626.c
> +++ b/drivers/staging/comedi/drivers/s626.c
> @@ -718,7 +718,7 @@ static uint16_t s626_get_mode_a(struct comedi_device *dev,
> uint16_t cra;
> uint16_t crb;
> uint16_t setup;
> - unsigned cntsrc, clkmult, clkpol, encmode;
> + unsigned int cntsrc, clkmult, clkpol, encmode;
>
> /* Fetch CRA and CRB register images. */
> cra = s626_debi_read(dev, S626_LP_CRA(chan));
> @@ -773,7 +773,7 @@ static uint16_t s626_get_mode_b(struct comedi_device *dev,
> uint16_t cra;
> uint16_t crb;
> uint16_t setup;
> - unsigned cntsrc, clkmult, clkpol, encmode;
> + unsigned int cntsrc, clkmult, clkpol, encmode;
>
> /* Fetch CRA and CRB register images. */
> cra = s626_debi_read(dev, S626_LP_CRA(chan));
> @@ -848,7 +848,7 @@ static void s626_set_mode_a(struct comedi_device *dev,
> struct s626_private *devpriv = dev->private;
> uint16_t cra;
> uint16_t crb;
> - unsigned cntsrc, clkmult, clkpol;
> + unsigned int cntsrc, clkmult, clkpol;
>
> /* Initialize CRA and CRB images. */
> /* Preload trigger is passed through. */
> @@ -926,7 +926,7 @@ static void s626_set_mode_b(struct comedi_device *dev,
> struct s626_private *devpriv = dev->private;
> uint16_t cra;
> uint16_t crb;
> - unsigned cntsrc, clkmult, clkpol;
> + unsigned int cntsrc, clkmult, clkpol;
>
> /* Initialize CRA and CRB images. */
> /* IndexSrc is passed through. */
>
Thanks!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
next prev parent reply other threads:[~2016-05-16 10:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 6:59 [PATCH 1/4] Staging: comedi: Fix WARNING issue in s626.c Ravishankar Karkala Mallikarjunayya
2016-05-12 6:59 ` [PATCH 2/4] Staging: comedi:Fix checkpatch " Ravishankar Karkala Mallikarjunayya
2016-05-16 10:02 ` Ian Abbott [this message]
2016-05-12 6:59 ` [PATCH 3/4] Staging: comedi: fix type " Ravishankar Karkala Mallikarjunayya
2016-05-16 10:07 ` Ian Abbott
2016-05-12 6:59 ` [PATCH 4/4] Staging: comedi: fix line over 80 characters " Ravishankar Karkala Mallikarjunayya
2016-05-16 10:09 ` Ian Abbott
2016-05-16 10:02 ` [PATCH 1/4] Staging: comedi: Fix WARNING " Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57399ABE.5060707@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ravishankarkm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox