From: Ian Abbott <abbotti@mev.co.uk>
To: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>,
hsweeten@visionengravers.com, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] Staging: comedi: Fix CHECK:Avoid CamelCase issue in daqboard2000.c
Date: Mon, 16 May 2016 11:47:08 +0100 [thread overview]
Message-ID: <5739A52C.8090704@mev.co.uk> (raw)
In-Reply-To: <1463393916-16243-2-git-send-email-ravishankarkm32@gmail.com>
On 16/05/16 11:18, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the daqboard2000.c file that fixes up a
> issues found by the checkpatch.pl tool.
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
> ---
> drivers/staging/comedi/drivers/daqboard2000.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c
> index a536a15..edd91a1 100644
> --- a/drivers/staging/comedi/drivers/daqboard2000.c
> +++ b/drivers/staging/comedi/drivers/daqboard2000.c
> @@ -116,12 +116,12 @@
> #define DAQBOARD2000_SUBSYSTEM_IDS4 0x0004 /* Daqboard/2000 - 4 Dacs */
>
> /* Initialization bits for the Serial EEPROM Control Register */
> -#define DAQBOARD2000_SECRProgPinHi 0x8001767e
> -#define DAQBOARD2000_SECRProgPinLo 0x8000767e
> -#define DAQBOARD2000_SECRLocalBusHi 0xc000767e
> -#define DAQBOARD2000_SECRLocalBusLo 0x8000767e
> -#define DAQBOARD2000_SECRReloadHi 0xa000767e
> -#define DAQBOARD2000_SECRReloadLo 0x8000767e
> +#define DAQBOARD2000_SECRPROGPINHI 0x8001767e
> +#define DAQBOARD2000_SECRPROGPINLO 0x8000767e
> +#define DAQBOARD2000_SECRLOCALBUSHI 0xc000767e
> +#define DAQBOARD2000_SECRLOCALBUSLO 0x8000767e
> +#define DAQBOARD2000_SECRRELOADHI 0xa000767e
> +#define DAQBOARD2000_SECRRELOADLO 0x8000767e
>
> /* SECR status bits */
> #define DAQBOARD2000_EEPROM_PRESENT 0x10000000
>
This doesn't compile. Also, there are several other CamelCase issues in
this driver, although probably too many to deal with in a single patch.
I'll have a shot at a slightly more extensive clean-up.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
next prev parent reply other threads:[~2016-05-16 10:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 10:18 [PATCH 5/6] Staging: comedi: Fix WARNING issue in dt2801.c Ravishankar Karkala Mallikarjunayya
2016-05-16 10:18 ` [PATCH 6/6] Staging: comedi: Fix CHECK:Avoid CamelCase issue in daqboard2000.c Ravishankar Karkala Mallikarjunayya
2016-05-16 10:47 ` Ian Abbott [this message]
2016-05-16 10:38 ` [PATCH 5/6] Staging: comedi: Fix WARNING issue in dt2801.c Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5739A52C.8090704@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ravishankarkm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox