From: Kieran Bingham <kieran@ksquared.org.uk>
To: Omar Sandoval <osandov@osandov.com>, Jan Kiszka <jan.kiszka@siemens.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] scripts/gdb: add constants.py to .gitignore
Date: Tue, 21 Jun 2016 22:20:14 +0100 [thread overview]
Message-ID: <5769AF8E.8040807@bingham.xyz> (raw)
In-Reply-To: <476a1d8754efec5957009db7ae4a9e10451faabb.1466543472.git.osandov@fb.com>
On 21/06/16 22:11, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
>
> Since scripts/gdb/linux/constants.py is autogenerated, this should have
> been added to .gitignore when it was introduced.
>
> Fixes: f197d75fcad1 ("scripts/gdb: provide linux constants")
> Signed-off-by: Omar Sandoval <osandov@fb.com>
> ---
> Thanks, Kieran, I totally missed the comment in top-level .gitignore.
>
> scripts/gdb/linux/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/gdb/linux/.gitignore b/scripts/gdb/linux/.gitignore
> index 52e4e61140d1..d5abd6ce9425 100644
> --- a/scripts/gdb/linux/.gitignore
> +++ b/scripts/gdb/linux/.gitignore
> @@ -1,2 +1,3 @@
> *.pyc
> *.pyo
> +/constants.py
Does this work with '/' at the beginning of the line?
It looks like all the other sub-tree .gitignores don't use a leading /
on their ignores
If you're happy, I'd like to drop the leading '/'.
(I think I can do this silently as I pick the patch if you approve,
rather than send another patch for a one-byte change)
Other than that:
Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
--
Regards
Kieran Bingham
next prev parent reply other threads:[~2016-06-21 21:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 21:11 [PATCH v2] scripts/gdb: add constants.py to .gitignore Omar Sandoval
2016-06-21 21:20 ` Kieran Bingham [this message]
2016-06-21 21:34 ` Omar Sandoval
2016-06-21 22:03 ` Kieran Bingham
2016-06-21 22:05 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5769AF8E.8040807@bingham.xyz \
--to=kieran@ksquared.org.uk \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox