[PATCH] drm/exynos: fix repeated words in comments

[PATCH] drm/exynos: fix repeated words in comments

[Jilin Yuan]

 Delete the redundant word 'next'.

Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
 drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
index 471fd6c8135f..4f9edca66632 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
@@ -1195,7 +1195,7 @@ int exynos_g2d_set_cmdlist_ioctl(struct drm_device *drm_dev, void *data,
 	 * If don't clear SFR registers, the cmdlist is affected by register
 	 * values of previous cmdlist. G2D hw executes SFR clear command and
 	 * a next command at the same time then the next command is ignored and
-	 * is executed rightly from next next command, so needs a dummy command
+	 * is executed rightly from next command, so needs a dummy command
 	 * to next command of SFR clear command.
 	 */
 	cmdlist->data[cmdlist->last++] = G2D_SOFT_RESET;
-- 
2.36.1

Re: [PATCH] drm/exynos: fix repeated words in comments

[Krzysztof Kozlowski]

On 23/08/2022 15:21, Jilin Yuan wrote:
>  Delete the redundant word 'next'.
> 

Use scripts/get_maintainers.pl to CC all maintainers and relevant
mailing lists.

Best regards,
Krzysztof

Re: [PATCH] drm/exynos: fix repeated words in comments

[Robin Murphy]

On 2022-08-23 13:21, Jilin Yuan wrote:
>   Delete the redundant word 'next'.

 From the context, I'm not sure it is redundant - as far as I can tell 
this comment seems to be describing a sequence of 3 commands, where 
"current" is the first, "next" is the second, and "next next" implies 
the third. The whole comment could certainly be reworded more clearly, 
but as it stands I suspect a replacement like s/next next/next+1/ is 
more likely to be correct.

Robin.

> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> ---
>   drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> index 471fd6c8135f..4f9edca66632 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> @@ -1195,7 +1195,7 @@ int exynos_g2d_set_cmdlist_ioctl(struct drm_device *drm_dev, void *data,
>   	 * If don't clear SFR registers, the cmdlist is affected by register
>   	 * values of previous cmdlist. G2D hw executes SFR clear command and
>   	 * a next command at the same time then the next command is ignored and
> -	 * is executed rightly from next next command, so needs a dummy command
> +	 * is executed rightly from next command, so needs a dummy command
>   	 * to next command of SFR clear command.
>   	 */
>   	cmdlist->data[cmdlist->last++] = G2D_SOFT_RESET;

Re: [PATCH] drm/exynos: fix repeated words in comments

[Inki Dae]

Hi,

2022년 8월 23일 (화) 오후 10:37, Robin Murphy <robin.murphy@arm.com>님이 작성:
>
> On 2022-08-23 13:21, Jilin Yuan wrote:
> >   Delete the redundant word 'next'.
>
>  From the context, I'm not sure it is redundant - as far as I can tell
> this comment seems to be describing a sequence of 3 commands, where
> "current" is the first, "next" is the second, and "next next" implies
> the third. The whole comment could certainly be reworded more clearly,
> but as it stands I suspect a replacement like s/next next/next+1/ is
> more likely to be correct.
>

"next next" is correct. :) As you said, "next next" could be reworded
more clearly. As of now, the original sentence could make it
confusing.

Thanks,
Inki Dae

> Robin.
>
> > Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> > ---
> >   drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> > index 471fd6c8135f..4f9edca66632 100644
> > --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> > +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> > @@ -1195,7 +1195,7 @@ int exynos_g2d_set_cmdlist_ioctl(struct drm_device *drm_dev, void *data,
> >        * If don't clear SFR registers, the cmdlist is affected by register
> >        * values of previous cmdlist. G2D hw executes SFR clear command and
> >        * a next command at the same time then the next command is ignored and
> > -      * is executed rightly from next next command, so needs a dummy command
> > +      * is executed rightly from next command, so needs a dummy command
> >        * to next command of SFR clear command.
> >        */
> >       cmdlist->data[cmdlist->last++] = G2D_SOFT_RESET;