From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] media: dt-bindings: Add qcom,sm6150-camss
Date: Tue, 28 Oct 2025 10:49:02 +0100 [thread overview]
Message-ID: <57bacdd4-67f9-4df5-855d-76dd31490454@kernel.org> (raw)
In-Reply-To: <20251016-sm6150-camss-v1-1-e7f64ac32370@oss.qualcomm.com>
On 16/10/2025 12:22, Wenmeng Liu wrote:
> Add bindings for qcom,sm6150-camss in order to support the camera
> subsystem found in Qualcomm Talos EVK board.
>
> Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
> ---
> .../bindings/media/qcom,sm6150-camss.yaml | 283 +++++++++++++++++++++
> 1 file changed, 283 insertions(+)
Please implement/go through same comments I gave to Luca.
https://lore.kernel.org/all/20251028-defiant-visionary-rottweiler-f97cda@kuoka/
It is somehow huge mess with camss with every binding re-inventing
names, resorting everything and keeping nothing in common.
I feel sad when looking at existing bindings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-28 9:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 10:22 [PATCH 0/3] media: qcom: camss: Add sm6150 camss support Wenmeng Liu
2025-10-16 10:22 ` [PATCH 1/3] media: dt-bindings: Add qcom,sm6150-camss Wenmeng Liu
2025-10-16 10:43 ` Bryan O'Donoghue
2025-10-16 13:00 ` Wenmeng Liu
2025-10-16 13:31 ` Vladimir Zapolskiy
2025-10-28 9:49 ` Krzysztof Kozlowski [this message]
2025-10-16 10:22 ` [PATCH 2/3] media: qcom: camss: add support for SM6150 camss Wenmeng Liu
2025-10-16 10:29 ` Bryan O'Donoghue
2025-10-16 12:36 ` Wenmeng Liu
2025-10-16 13:55 ` Bryan O'Donoghue
2025-10-16 13:43 ` Vladimir Zapolskiy
2025-10-16 10:22 ` [PATCH 3/3] arm64: dts: qcom: sm6150: Add camss node Wenmeng Liu
2025-10-16 13:48 ` Vladimir Zapolskiy
2025-10-22 16:02 ` Konrad Dybcio
2025-11-02 17:47 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57bacdd4-67f9-4df5-855d-76dd31490454@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
--cc=wenmeng.liu@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox