From: Bryan O'Donoghue <bod@kernel.org>
To: Wenmeng Liu <quic_wenmliu@qualcomm.com>,
Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] media: qcom: camss: add support for SM6150 camss
Date: Thu, 16 Oct 2025 14:55:20 +0100 [thread overview]
Message-ID: <aedc5761-75da-42bf-9147-dcde24c8e976@kernel.org> (raw)
In-Reply-To: <e4be125c-752e-46c9-9637-fe23cbf04b1a@qualcomm.com>
On 16/10/2025 13:36, Wenmeng Liu wrote:
>>> + case CAMSS_6150:
>>> regs->lane_regs = &lane_regs_qcm2290[0];
>> You don't need to specify the array index for that.
>>
> Here I have only added "case CAMSS_6150:", then do I need to modify the
> part of "&lane_regs_qcm2290[0]"?
Hmm no I'm wrong - again.
Please don't be afraid to call people out on being wrong - like I am now.
Existing code is:
case CAMSS_X1E80100:
regs->lane_regs = &lane_regs_x1e80100[0];
regs->lane_array_size = ARRAY_SIZE(lane_regs_x1e80100);
regs->offset = 0x1000;
break;
case CAMSS_8550:
regs->lane_regs = &lane_regs_sm8550[0];
regs->lane_array_size = ARRAY_SIZE(lane_regs_sm8550);
regs->offset = 0x1000;
Your comment is consistent with existing code.
You may ignore the previous statement.
---
bod
next prev parent reply other threads:[~2025-10-16 13:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 10:22 [PATCH 0/3] media: qcom: camss: Add sm6150 camss support Wenmeng Liu
2025-10-16 10:22 ` [PATCH 1/3] media: dt-bindings: Add qcom,sm6150-camss Wenmeng Liu
2025-10-16 10:43 ` Bryan O'Donoghue
2025-10-16 13:00 ` Wenmeng Liu
2025-10-16 13:31 ` Vladimir Zapolskiy
2025-10-28 9:49 ` Krzysztof Kozlowski
2025-10-16 10:22 ` [PATCH 2/3] media: qcom: camss: add support for SM6150 camss Wenmeng Liu
2025-10-16 10:29 ` Bryan O'Donoghue
2025-10-16 12:36 ` Wenmeng Liu
2025-10-16 13:55 ` Bryan O'Donoghue [this message]
2025-10-16 13:43 ` Vladimir Zapolskiy
2025-10-16 10:22 ` [PATCH 3/3] arm64: dts: qcom: sm6150: Add camss node Wenmeng Liu
2025-10-16 13:48 ` Vladimir Zapolskiy
2025-10-22 16:02 ` Konrad Dybcio
2025-11-02 17:47 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aedc5761-75da-42bf-9147-dcde24c8e976@kernel.org \
--to=bod@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_wenmliu@qualcomm.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
--cc=wenmeng.liu@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox