* [PATCH] drm/i915: Use ERR_CAST instead of ERR_PTR(PTR_ERR())
@ 2021-10-25 11:32 Wan Jiabing
2021-10-25 15:42 ` Matthew Auld
0 siblings, 1 reply; 2+ messages in thread
From: Wan Jiabing @ 2021-10-25 11:32 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
Daniel Vetter, Chris Wilson, Maarten Lankhorst, Jason Ekstrand,
Matthew Auld, Matthew Brost, intel-gfx, dri-devel, linux-kernel
Cc: kael_w, Wan Jiabing
Fix following coccicheck warning:
./drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:3117:15-22: WARNING:
ERR_CAST can be used with eb->requests[i].
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index 4d7da07442f2..eb2dcaf78d08 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -3114,7 +3114,7 @@ eb_requests_create(struct i915_execbuffer *eb, struct dma_fence *in_fence,
/* Allocate a request for this batch buffer nice and early. */
eb->requests[i] = i915_request_create(eb_find_context(eb, i));
if (IS_ERR(eb->requests[i])) {
- out_fence = ERR_PTR(PTR_ERR(eb->requests[i]));
+ out_fence = ERR_CAST(eb->requests[i]);
eb->requests[i] = NULL;
return out_fence;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/i915: Use ERR_CAST instead of ERR_PTR(PTR_ERR())
2021-10-25 11:32 [PATCH] drm/i915: Use ERR_CAST instead of ERR_PTR(PTR_ERR()) Wan Jiabing
@ 2021-10-25 15:42 ` Matthew Auld
0 siblings, 0 replies; 2+ messages in thread
From: Matthew Auld @ 2021-10-25 15:42 UTC (permalink / raw)
To: Wan Jiabing, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
David Airlie, Daniel Vetter, Chris Wilson, Maarten Lankhorst,
Jason Ekstrand, Matthew Brost, intel-gfx, dri-devel, linux-kernel
Cc: kael_w
On 25/10/2021 12:32, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:3117:15-22: WARNING:
> ERR_CAST can be used with eb->requests[i].
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Pushed to drm-intel-gt-next. Thanks.
> ---
> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> index 4d7da07442f2..eb2dcaf78d08 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> @@ -3114,7 +3114,7 @@ eb_requests_create(struct i915_execbuffer *eb, struct dma_fence *in_fence,
> /* Allocate a request for this batch buffer nice and early. */
> eb->requests[i] = i915_request_create(eb_find_context(eb, i));
> if (IS_ERR(eb->requests[i])) {
> - out_fence = ERR_PTR(PTR_ERR(eb->requests[i]));
> + out_fence = ERR_CAST(eb->requests[i]);
> eb->requests[i] = NULL;
> return out_fence;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-25 15:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-25 11:32 [PATCH] drm/i915: Use ERR_CAST instead of ERR_PTR(PTR_ERR()) Wan Jiabing
2021-10-25 15:42 ` Matthew Auld
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox