The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
	mingo@redhat.com, alexander.shishkin@linux.intel.com,
	Linux-kernel@vger.kernel.org, ak@linux.intel.com,
	kan.liang@intel.com, yao.jin@intel.com, ying.huang@intel.com
Subject: Re: [PATCH v8] perf stat: Fix wrong skipping for per-die aggregation
Date: Thu, 28 Jan 2021 09:25:57 +0800	[thread overview]
Message-ID: <58796d6e-fceb-ea1f-3a83-543569d5625c@linux.intel.com> (raw)
In-Reply-To: <20210127220827.GB284633@krava>

Hi Jiri,

On 1/28/2021 6:08 AM, Jiri Olsa wrote:
>> @@ -1385,7 +1386,8 @@ void evsel__exit(struct evsel *evsel)
>>   	zfree(&evsel->group_name);
>>   	zfree(&evsel->name);
>>   	zfree(&evsel->pmu_name);
>> -	zfree(&evsel->per_pkg_mask);
> sorry I did not notice before, but I think we need to call
> zero_per_pkg in here, otherwise we're leaking keys
> 
> jirka
> 

Sorry, I forgot to add the release code here. :(

I will rename zero_per_pkg to evsel__zero_per_pkg and move it to evsel.c and call 
evsel__zero_per_pkg in evsel__exit().

Thanks
Jin Yao



      reply	other threads:[~2021-01-28  1:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25 23:35 [PATCH v8] perf stat: Fix wrong skipping for per-die aggregation Jin Yao
2021-01-27 22:08 ` Jiri Olsa
2021-01-28  1:25   ` Jin, Yao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58796d6e-fceb-ea1f-3a83-543569d5625c@linux.intel.com \
    --to=yao.jin@linux.intel.com \
    --cc=Linux-kernel@vger.kernel.org \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=yao.jin@intel.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox