public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Derek J. Clark" <derekjohn.clark@gmail.com>
To: no name <cd345al@gmail.com>, mpearson-lenovo@squebb.ca, i@rong.moe
Cc: hansg@kernel.org, ilpo.jarvinen@linux.intel.com,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86: lenovo: wmi-other: Fix uninitialized
Date: Sun, 26 Apr 2026 11:47:10 -0700	[thread overview]
Message-ID: <5BB41C4A-12DC-4059-9C97-CBBA4226DFC6@gmail.com> (raw)
In-Reply-To: <CALoEd=GncBHeSOh7eqmVaJrKWNGLsFEyh5TsF87boSQgsDM0vg@mail.gmail.com>

On April 26, 2026 11:38:35 AM PDT, no name <cd345al@gmail.com> wrote:
>Hi, Derek,
>Thanks for your reply!
>
>On Mon, Apr 27, 2026 at 2:22 AM Derek J. Clark
><derekjohn.clark@gmail.com> wrote:
>> Hi Yufei,
>>
>> This bug is already addressed in a patch series that has been submitted and is awaiting review from the subsystem maintainers.
>>
>Which bug do you mean specifically? The args.arg1 uninitialized bug,
>or the original uninitialized 'raw' variable, or the inappropriate
>encapsulation?

I was replying to that specific part of your email,  regarding the args initializing. 

See <https://lore.kernel.org/platform-driver-x86/20260412211121.2220556-1-derekjohn.clark@gmail.com/T/#mc7f4ab5f74cd2fa21eedcb6d91488b76d3ba3f31>

Thanks,
Derek

>> >I may do some refactor recently, and I'm happy to hear your suggestions.
>>
>> Rong has a large refactor series queued up to simplify much of the driver already, pending the acceptance of the previously mentioned series. It would be best to avoid doing any additional large refactoring until that series has landed.
>>
>OK, that sounds good. I'll wait until the refactor is done. I hope my
>suggestions can be adopted or we can discuss further about the
>appropriate architecture. I'm happy to hear your suggestions.
>
>Thanks,
>Yufei


  reply	other threads:[~2026-04-26 18:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-26 14:59 [PATCH v2] platform/x86: lenovo: wmi-other: Fix uninitialized variable in lwmi_om_hwmon_write() Yufei CHENG
2026-04-26 16:07 ` Rong Zhang
2026-04-26 17:43   ` [PATCH v2] platform/x86: lenovo: wmi-other: Fix uninitialized Yufei CHENG
2026-04-26 18:22     ` Derek J. Clark
2026-04-26 18:38       ` no name
2026-04-26 18:47         ` Derek J. Clark [this message]
2026-04-27  1:14           ` no name
2026-04-26 16:50 ` [PATCH v3] platform/x86: lenovo: wmi-other: Fix uninitialized variable in lwmi_om_hwmon_write() Yufei CHENG
2026-04-30 13:54   ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5BB41C4A-12DC-4059-9C97-CBBA4226DFC6@gmail.com \
    --to=derekjohn.clark@gmail.com \
    --cc=cd345al@gmail.com \
    --cc=hansg@kernel.org \
    --cc=i@rong.moe \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpearson-lenovo@squebb.ca \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox