Re: [PATCH v4 1/1] arm64: dts: exynosautov920: add watchdog DT node

[Krzysztof Kozlowski <krzk@kernel.org>]

On 11/12/2024 02:50, 김태완 wrote:
> on 11/12/2024 01:50 UTC+09:00, Taewan Kim wrote:
>>> From: Byoungtae Cho <bt.cho@samsung.com>
>>>
>>> Adds two watchdog devices for ExynosAutoV920 SoC.
>>>
>>> Signed-off-by: Byoungtae Cho <bt.cho@samsung.com>
>>> Signed-off-by: Taewan Kim <trunixs.kim@samsung.com>
>>> ---
>>>  .../arm64/boot/dts/exynos/exynosautov920.dtsi | 20 +++++++++++++++++++
>>>  1 file changed, 20 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
>> b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
>>> index c759134c909e..7b9591255e91 100644
>>> --- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
>>> +++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
>>> @@ -183,6 +183,26 @@ cmu_misc: clock-controller@10020000 {
>>>  				      "noc";
>>>  		};
>>>
>>> +		watchdog_cl0: watchdog@10060000 {
>>
>> You need to do careful rebase, not just accept whatever tools shown you.
>>
>> This is now placed in incorrect order - not keeping sorting by unit address.
> 
> I seems to me that the addresses are sorted correctly in order. 
> Could you kindly check again?
> 
>         clock-controller@1002_0000
>                   watchdog@1006_0000 
>                   watchdog@1007_0000
>     interrupt-controller@1040_0000
> 
> And if there are any rules I might not be aware of, please let me know.


You are right, I got impression last was 1004, but that's 1040. Thanks
for correcting me. I applied now.


Best regards,
Krzysztof