From: 김태완 <trunixs.kim@samsung.com>
To: "'Krzysztof Kozlowski'" <krzk@kernel.org>,
"'Wim Van Sebroeck'" <wim@linux-watchdog.org>,
"'Guenter Roeck'" <linux@roeck-us.net>,
"'Rob Herring'" <robh@kernel.org>,
"'Krzysztof Kozlowski'" <krzk+dt@kernel.org>,
"'Conor Dooley'" <conor+dt@kernel.org>,
"'Alim Akhtar'" <alim.akhtar@samsung.com>
Cc: <linux-watchdog@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
"'Byoungtae Cho'" <bt.cho@samsung.com>
Subject: RE: [PATCH v4 1/1] arm64: dts: exynosautov920: add watchdog DT node
Date: Wed, 11 Dec 2024 10:50:27 +0900 [thread overview]
Message-ID: <000101db4b6f$0d31c460$27954d20$@samsung.com> (raw)
In-Reply-To: <510e826d-a434-437d-8d2e-3f2618c28b7f@kernel.org>
on 11/12/2024 01:50 UTC+09:00, Taewan Kim wrote:
>> From: Byoungtae Cho <bt.cho@samsung.com>
>>
>> Adds two watchdog devices for ExynosAutoV920 SoC.
>>
>> Signed-off-by: Byoungtae Cho <bt.cho@samsung.com>
>> Signed-off-by: Taewan Kim <trunixs.kim@samsung.com>
>> ---
>> .../arm64/boot/dts/exynos/exynosautov920.dtsi | 20 +++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
>b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
>> index c759134c909e..7b9591255e91 100644
>> --- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
>> +++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
>> @@ -183,6 +183,26 @@ cmu_misc: clock-controller@10020000 {
>> "noc";
>> };
>>
>> + watchdog_cl0: watchdog@10060000 {
>
>You need to do careful rebase, not just accept whatever tools shown you.
>
>This is now placed in incorrect order - not keeping sorting by unit address.
I seems to me that the addresses are sorted correctly in order.
Could you kindly check again?
clock-controller@1002_0000
watchdog@1006_0000
watchdog@1007_0000
interrupt-controller@1040_0000
And if there are any rules I might not be aware of, please let me know.
Best regards,
Taewan Kim
next prev parent reply other threads:[~2024-12-11 1:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20241206025156epcas2p3e1ce9ff35589d821735a7c038b9ac9da@epcas2p3.samsung.com>
2024-12-06 2:51 ` [PATCH v4 0/1] support watchdog for exynosautov920 Taewan Kim
2024-12-06 2:51 ` [PATCH v4 1/1] arm64: dts: exynosautov920: add watchdog DT node Taewan Kim
2024-12-06 8:48 ` Krzysztof Kozlowski
2024-12-11 1:50 ` 김태완 [this message]
2024-12-11 7:50 ` Krzysztof Kozlowski
2024-12-11 7:50 ` [PATCH v4 0/1] support watchdog for exynosautov920 Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000101db4b6f$0d31c460$27954d20$@samsung.com' \
--to=trunixs.kim@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=bt.cho@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox