[PATCH v4 0/1] support watchdog for exynosautov920

[PATCH v4 0/1] support watchdog for exynosautov920

[Taewan Kim]

Add support for the ExynosAutoV920 SoC. Basically this is almost
similar to ExynosAuto V9 or Exynos850 such as two watchdog instance for
each cluster but some CPU configuration are quite different.
Therefore device tree, compatibles and drvdata should be added.

In v3, the first and second patches were approved by watchdog maintainer and added as next-git.
- Link: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/?qt=grep&q=bt.cho

For the last third dts patch review, the patch was rebased and made v4.

---
Changes in v4:
- The first two patches were approved in v3.(1/3, 2/3)
- v4 contains only one patch that needs to be reviewed. (3/3)
- Rebase to the lastest master branch
- Link to v3: https://lore.kernel.org/all/20241021063903.793166-1-trunixs.kim@samsung.com/
---
Changes in v3:
- Add Acked-by/Reviewed-by tags 
- Link to v2: https://lore.kernel.org/all/20241010111807.3635504-1-trunixs.kim@samsung.com/
---
Changes in v2:
- Add a space before }
- Fix worng variant condition (cl1 -> cl0)
- Move the location declaring watchdog node
  to the correct location that fits the DTS coding rules
- Link to v1: https://lore.kernel.org/all/20240913080325.3676181-1-trunixs.kim@samsung.com/
---

Byoungtae Cho (1):
  arm64: dts: exynosautov920: add watchdog DT node

 .../arm64/boot/dts/exynos/exynosautov920.dtsi | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

-- 
2.47.1

[PATCH v4 1/1] arm64: dts: exynosautov920: add watchdog DT node

[Taewan Kim]

From: Byoungtae Cho <bt.cho@samsung.com>

Adds two watchdog devices for ExynosAutoV920 SoC.

Signed-off-by: Byoungtae Cho <bt.cho@samsung.com>
Signed-off-by: Taewan Kim <trunixs.kim@samsung.com>
---
 .../arm64/boot/dts/exynos/exynosautov920.dtsi | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
index c759134c909e..7b9591255e91 100644
--- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
@@ -183,6 +183,26 @@ cmu_misc: clock-controller@10020000 {
 				      "noc";
 		};
 
+		watchdog_cl0: watchdog@10060000 {
+			compatible = "samsung,exynosautov920-wdt";
+			reg = <0x10060000 0x100>;
+			interrupts = <GIC_SPI 953 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&xtcxo>, <&xtcxo>;
+			clock-names = "watchdog", "watchdog_src";
+			samsung,syscon-phandle = <&pmu_system_controller>;
+			samsung,cluster-index = <0>;
+		};
+
+		watchdog_cl1: watchdog@10070000 {
+			compatible = "samsung,exynosautov920-wdt";
+			reg = <0x10070000 0x100>;
+			interrupts = <GIC_SPI 952 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&xtcxo>, <&xtcxo>;
+			clock-names = "watchdog", "watchdog_src";
+			samsung,syscon-phandle = <&pmu_system_controller>;
+			samsung,cluster-index = <1>;
+		};
+
 		gic: interrupt-controller@10400000 {
 			compatible = "arm,gic-v3";
 			#interrupt-cells = <3>;
-- 
2.47.1

Re: [PATCH v4 1/1] arm64: dts: exynosautov920: add watchdog DT node

[Krzysztof Kozlowski]

On 06/12/2024 03:51, Taewan Kim wrote:
> From: Byoungtae Cho <bt.cho@samsung.com>
> 
> Adds two watchdog devices for ExynosAutoV920 SoC.
> 
> Signed-off-by: Byoungtae Cho <bt.cho@samsung.com>
> Signed-off-by: Taewan Kim <trunixs.kim@samsung.com>
> ---
>  .../arm64/boot/dts/exynos/exynosautov920.dtsi | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> index c759134c909e..7b9591255e91 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> @@ -183,6 +183,26 @@ cmu_misc: clock-controller@10020000 {
>  				      "noc";
>  		};
>  
> +		watchdog_cl0: watchdog@10060000 {

You need to do careful rebase, not just accept whatever tools shown you.

This is now placed in incorrect order - not keeping sorting by unit address.

Best regards,
Krzysztof

RE: [PATCH v4 1/1] arm64: dts: exynosautov920: add watchdog DT node

[김태완]

on 11/12/2024 01:50 UTC+09:00, Taewan Kim wrote:
>> From: Byoungtae Cho <bt.cho@samsung.com>
>>
>> Adds two watchdog devices for ExynosAutoV920 SoC.
>>
>> Signed-off-by: Byoungtae Cho <bt.cho@samsung.com>
>> Signed-off-by: Taewan Kim <trunixs.kim@samsung.com>
>> ---
>>  .../arm64/boot/dts/exynos/exynosautov920.dtsi | 20 +++++++++++++++++++
>>  1 file changed, 20 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
>b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
>> index c759134c909e..7b9591255e91 100644
>> --- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
>> +++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
>> @@ -183,6 +183,26 @@ cmu_misc: clock-controller@10020000 {
>>  				      "noc";
>>  		};
>>
>> +		watchdog_cl0: watchdog@10060000 {
>
>You need to do careful rebase, not just accept whatever tools shown you.
>
>This is now placed in incorrect order - not keeping sorting by unit address.

I seems to me that the addresses are sorted correctly in order. 
Could you kindly check again?

        clock-controller@1002_0000
                  watchdog@1006_0000 
                  watchdog@1007_0000
    interrupt-controller@1040_0000

And if there are any rules I might not be aware of, please let me know.

Best regards,
Taewan Kim

Re: [PATCH v4 0/1] support watchdog for exynosautov920

[Krzysztof Kozlowski]

On Fri, 06 Dec 2024 11:51:37 +0900, Taewan Kim wrote:
> Add support for the ExynosAutoV920 SoC. Basically this is almost
> similar to ExynosAuto V9 or Exynos850 such as two watchdog instance for
> each cluster but some CPU configuration are quite different.
> Therefore device tree, compatibles and drvdata should be added.
> 
> In v3, the first and second patches were approved by watchdog maintainer and added as next-git.
> - Link: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/?qt=grep&q=bt.cho
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: exynosautov920: add watchdog DT node
      https://git.kernel.org/krzk/linux/c/41979b81b22a35322817733b15407167164be58e

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Re: [PATCH v4 1/1] arm64: dts: exynosautov920: add watchdog DT node

[Krzysztof Kozlowski]

On 11/12/2024 02:50, 김태완 wrote:
> on 11/12/2024 01:50 UTC+09:00, Taewan Kim wrote:
>>> From: Byoungtae Cho <bt.cho@samsung.com>
>>>
>>> Adds two watchdog devices for ExynosAutoV920 SoC.
>>>
>>> Signed-off-by: Byoungtae Cho <bt.cho@samsung.com>
>>> Signed-off-by: Taewan Kim <trunixs.kim@samsung.com>
>>> ---
>>>  .../arm64/boot/dts/exynos/exynosautov920.dtsi | 20 +++++++++++++++++++
>>>  1 file changed, 20 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
>> b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
>>> index c759134c909e..7b9591255e91 100644
>>> --- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
>>> +++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
>>> @@ -183,6 +183,26 @@ cmu_misc: clock-controller@10020000 {
>>>  				      "noc";
>>>  		};
>>>
>>> +		watchdog_cl0: watchdog@10060000 {
>>
>> You need to do careful rebase, not just accept whatever tools shown you.
>>
>> This is now placed in incorrect order - not keeping sorting by unit address.
> 
> I seems to me that the addresses are sorted correctly in order. 
> Could you kindly check again?
> 
>         clock-controller@1002_0000
>                   watchdog@1006_0000 
>                   watchdog@1007_0000
>     interrupt-controller@1040_0000
> 
> And if there are any rules I might not be aware of, please let me know.


You are right, I got impression last was 1004, but that's 1040. Thanks
for correcting me. I applied now.


Best regards,
Krzysztof