The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: vivek t s <vivek6429.ts@gmail.com>, gregkh@linuxfoundation.org
Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Staging: rtl8723bs: Rename function SelectChannel()
Date: Wed, 28 Aug 2024 22:25:56 +0200	[thread overview]
Message-ID: <5cbf98cf-9b1a-455e-afcd-b0cdfcf1aaec@gmail.com> (raw)
In-Reply-To: <Zs8WLkzoZe3Z0DYF@victor-IdeaPad-Gaming-3-16IAH7>

On 8/28/24 14:21, vivek t s wrote:
> Rename SelectChannel() to r8723bs_select_channel() to avoid CamelCase
> warning from checkpatch.
> 
> Signed-off-by: vivek t s<vivek6429.ts@gmail.com>

Hi Vivek,

the description can be improved. Please always consider that checkpatch 
can be wrong. So checkpatch is not a justification.

I propose (feel free to improve):
Rename function SelectChannel() to r8723bs_select_channel() to avoid
CamelCase and to improve cleanliness of the global namespace.

Thanks for your support.

Bye Philipp

  reply	other threads:[~2024-08-28 20:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-28 12:21 [PATCH v2] Staging: rtl8723bs: Rename function SelectChannel() vivek t s
2024-08-28 20:25 ` Philipp Hortmann [this message]
2024-08-30 14:52   ` YOUR NAME

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5cbf98cf-9b1a-455e-afcd-b0cdfcf1aaec@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=dan.carpenter@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=vivek6429.ts@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox