[PATCH v2] Staging: rtl8723bs: Rename function SelectChannel()

[PATCH v2] Staging: rtl8723bs: Rename function SelectChannel()

[vivek t s]

Rename SelectChannel() to r8723bs_select_channel() to avoid CamelCase
warning from checkpatch.

Signed-off-by: vivek t s <vivek6429.ts@gmail.com>
---
compile tested.

V2: Prefix added for function as suggested by Greg Kroah-Hartman
    <gregkh@linuxfoundation.org>.
    Commit message corrections as suggested by Dan Carpenter
    <dan.carpenter@linaro.org>.

 drivers/staging/rtl8723bs/core/rtw_ap.c          | 4 ++--
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c    | 4 ++--
 drivers/staging/rtl8723bs/core/rtw_wlan_util.c   | 2 +-
 drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index e4063713fecc..23268ec502a7 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -277,7 +277,7 @@ void expire_timeout_chk(struct adapter *padapter)
 		/* switch to correct channel of current network  before issue keep-alive frames */
 		if (rtw_get_oper_ch(padapter) != pmlmeext->cur_channel) {
 			backup_oper_channel = rtw_get_oper_ch(padapter);
-			SelectChannel(padapter, pmlmeext->cur_channel);
+			r8723bs_select_channel(padapter, pmlmeext->cur_channel);
 		}
 
 		/* issue null data to check sta alive*/
@@ -315,7 +315,7 @@ void expire_timeout_chk(struct adapter *padapter)
 		}
 
 		if (backup_oper_channel > 0) /* back to the original operation channel */
-			SelectChannel(padapter, backup_oper_channel);
+			r8723bs_select_channel(padapter, backup_oper_channel);
 	}
 
 	associated_clients_update(padapter, updated);
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index 9ebf25a0ef9b..60861a480b3b 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -3831,10 +3831,10 @@ void site_survey(struct adapter *padapter)
 		} else {
 #ifdef DBG_FIXED_CHAN
 			if (pmlmeext->fixed_chan != 0xff)
-				SelectChannel(padapter, pmlmeext->fixed_chan);
+				r8723bs_select_channel(padapter, pmlmeext->fixed_chan);
 			else
 #endif
-				SelectChannel(padapter, survey_channel);
+				r8723bs_select_channel(padapter, survey_channel);
 		}
 
 		if (ScanType == SCAN_ACTIVE) { /* obey the channel plan setting... */
diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
index 7fac9ca3e9a0..87ce4a9b3aad 100644
--- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
+++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
@@ -333,7 +333,7 @@ inline unsigned long rtw_get_on_cur_ch_time(struct adapter *adapter)
 		return 0;
 }
 
-void SelectChannel(struct adapter *padapter, unsigned char channel)
+void r8723bs_select_channel(struct adapter *padapter, unsigned char channel)
 {
 	if (mutex_lock_interruptible(&(adapter_to_dvobj(padapter)->setch_mutex)))
 		return;
diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
index 720aeeb002b0..8315399b64fd 100644
--- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
+++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
@@ -455,7 +455,7 @@ u8 rtw_get_center_ch(u8 channel, u8 chnl_bw, u8 chnl_offset);
 unsigned long rtw_get_on_cur_ch_time(struct adapter *adapter);
 
 void set_channel_bwmode(struct adapter *padapter, unsigned char channel, unsigned char channel_offset, unsigned short bwmode);
-void SelectChannel(struct adapter *padapter, unsigned char channel);
+void r8723bs_select_channel(struct adapter *padapter, unsigned char channel);
 
 unsigned int decide_wait_for_beacon_timeout(unsigned int bcn_interval);
 
-- 
2.43.0

Re: [PATCH v2] Staging: rtl8723bs: Rename function SelectChannel()

[Philipp Hortmann]

On 8/28/24 14:21, vivek t s wrote:
> Rename SelectChannel() to r8723bs_select_channel() to avoid CamelCase
> warning from checkpatch.
> 
> Signed-off-by: vivek t s<vivek6429.ts@gmail.com>

Hi Vivek,

the description can be improved. Please always consider that checkpatch 
can be wrong. So checkpatch is not a justification.

I propose (feel free to improve):
Rename function SelectChannel() to r8723bs_select_channel() to avoid
CamelCase and to improve cleanliness of the global namespace.

Thanks for your support.

Bye Philipp

Re: [PATCH v2] Staging: rtl8723bs: Rename function SelectChannel()

[YOUR NAME]

On Wed, Aug 28, 2024 at 10:25:56PM +0200, Philipp Hortmann wrote:
> On 8/28/24 14:21, vivek t s wrote:
> > Rename SelectChannel() to r8723bs_select_channel() to avoid CamelCase
> > warning from checkpatch.
> > 
> > Signed-off-by: vivek t s<vivek6429.ts@gmail.com>
> 
> Hi Vivek,
> 
> the description can be improved. Please always consider that checkpatch can
> be wrong. So checkpatch is not a justification.
> 
> I propose (feel free to improve):
> Rename function SelectChannel() to r8723bs_select_channel() to avoid
> CamelCase and to improve cleanliness of the global namespace.
> 
> Thanks for your support.
> 
> Bye Philipp

okay, understood.
i shall change the description and send again.

thanks,
vivek