From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Jason-JH.Lin" <jason-jh.lin@mediatek.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: Conor Dooley <conor+dt@kernel.org>,
Jason-ch Chen <jason-ch.chen@mediatek.com>,
Johnson Wang <johnson.wang@mediatek.com>,
Elvis Wang <Elvis.Wang@mediatek.com>,
Singo Chang <singo.chang@mediatek.com>,
Nancy Lin <nancy.lin@mediatek.com>,
Shawn Sung <shawn.sung@mediatek.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
dri-devel@lists.freedesktop.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH 07/15] mailbox: mediatek: Add loop pkt flag and irq handling for loop command
Date: Sat, 23 Sep 2023 20:03:43 +0200 [thread overview]
Message-ID: <5d528036-e506-7b95-69bb-7748b26d2aa8@linaro.org> (raw)
In-Reply-To: <20230918192204.32263-8-jason-jh.lin@mediatek.com>
On 18/09/2023 21:21, Jason-JH.Lin wrote:
> CMDQ client can use a loop flag for the CMDQ packet to make current
> command buffer jumps to the beginning when GCE executes to the end
> of commands buffer.
>
> GCE irq occurs when GCE executes to the end of command instruction.
> If the CMDQ packet is a loopping command, GCE irq handler can not
> delete the CMDQ task and disable the GCE thread.
>
> Add cmdq_mbox_stop to support thread disable
How or where do you add it? I do not see it in this patch. Your patchset
looks randomly organized.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-23 18:03 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230918192204.32263-1-jason-jh.lin@mediatek.com>
[not found] ` <20230918192204.32263-7-jason-jh.lin@mediatek.com>
2023-09-19 1:24 ` [PATCH 06/15] mailbox: mediatek: Add cmdq_mbox_stop to disable GCE thread CK Hu (胡俊光)
2023-09-21 14:15 ` Jason-JH Lin (林睿祥)
2023-09-23 18:02 ` Krzysztof Kozlowski
2023-09-25 5:10 ` Jason-JH Lin (林睿祥)
2023-09-23 18:07 ` Krzysztof Kozlowski
2023-09-25 5:25 ` Jason-JH Lin (林睿祥)
[not found] ` <20230918192204.32263-9-jason-jh.lin@mediatek.com>
2023-09-19 1:38 ` [PATCH 08/15] soc: mediatek: Add cmdq_pkt_finalize_loop to CMDQ driver CK Hu (胡俊光)
2023-09-21 14:25 ` Jason-JH Lin (林睿祥)
2023-09-23 18:04 ` Krzysztof Kozlowski
2023-09-23 18:08 ` Krzysztof Kozlowski
2023-09-25 6:04 ` Jason-JH Lin (林睿祥)
2023-09-25 6:40 ` Krzysztof Kozlowski
[not found] ` <20230918192204.32263-12-jason-jh.lin@mediatek.com>
2023-09-19 3:04 ` [PATCH 11/15] soc: mediatek: Add cmdq_insert_backup_cookie before EOC for secure pkt CK Hu (胡俊光)
2023-09-21 14:28 ` Jason-JH Lin (林睿祥)
[not found] ` <20230918192204.32263-2-jason-jh.lin@mediatek.com>
2023-09-19 16:46 ` [PATCH 01/15] dt-bindings: mailbox: Add property for CMDQ secure driver Rob Herring
2023-09-21 15:12 ` Jason-JH Lin (林睿祥)
2023-09-20 3:08 ` [PATCH 00/15] Add CMDQ secure driver for SVP CK Hu (胡俊光)
2023-09-21 14:44 ` Jason-JH Lin (林睿祥)
[not found] ` <20230918192204.32263-3-jason-jh.lin@mediatek.com>
2023-09-23 18:01 ` [PATCH 02/15] dt-bindings: gce: mt8195: Add CMDQ_SYNC_TOKEN_SECURE_THR_EOF event id Krzysztof Kozlowski
2023-09-25 5:05 ` Jason-JH Lin (林睿祥)
2023-09-25 6:42 ` Krzysztof Kozlowski
2023-09-25 9:11 ` Jason-JH Lin (林睿祥)
2023-09-25 9:28 ` Krzysztof Kozlowski
2023-09-26 2:45 ` Jason-JH Lin (林睿祥)
[not found] ` <20230918192204.32263-4-jason-jh.lin@mediatek.com>
2023-09-23 18:02 ` [PATCH 03/15] soc: mailbox: Add SPR definition for GCE Krzysztof Kozlowski
2023-09-25 5:08 ` Jason-JH Lin (林睿祥)
2023-09-25 6:42 ` Krzysztof Kozlowski
2023-09-25 10:24 ` Jason-JH Lin (林睿祥)
[not found] ` <20230918192204.32263-8-jason-jh.lin@mediatek.com>
2023-09-23 18:03 ` Krzysztof Kozlowski [this message]
2023-09-25 5:21 ` [PATCH 07/15] mailbox: mediatek: Add loop pkt flag and irq handling for loop command Jason-JH Lin (林睿祥)
2023-09-25 6:44 ` Krzysztof Kozlowski
2023-09-26 3:20 ` Jason-JH Lin (林睿祥)
2023-09-26 20:32 ` Krzysztof Kozlowski
[not found] ` <20230918192204.32263-15-jason-jh.lin@mediatek.com>
2023-09-23 18:08 ` [PATCH 14/15] mailbox: mediatek: Add mt8195 support for CMDQ secure driver Krzysztof Kozlowski
2023-09-25 5:48 ` Jason-JH Lin (林睿祥)
[not found] ` <20230918192204.32263-14-jason-jh.lin@mediatek.com>
2023-09-23 18:09 ` [PATCH 13/15] mailbox: mediatek: Add mt8188 " Krzysztof Kozlowski
2023-09-25 6:01 ` Jason-JH Lin (林睿祥)
2023-09-25 6:45 ` Krzysztof Kozlowski
2023-09-25 9:02 ` Jason-JH Lin (林睿祥)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d528036-e506-7b95-69bb-7748b26d2aa8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Elvis.Wang@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jason-ch.chen@mediatek.com \
--cc=jason-jh.lin@mediatek.com \
--cc=jassisinghbrar@gmail.com \
--cc=johnson.wang@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nancy.lin@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=shawn.sung@mediatek.com \
--cc=singo.chang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox